public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Shida Zhang <zhangshida@kylinos.cn>, k2ci <kernel-bot@kylinos.cn>,
	Anand Jain <anand.jain@oracle.com>,
	David Sterba <dsterba@suse.com>, Sasha Levin <sashal@kernel.org>,
	clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org
Subject: [PATCH AUTOSEL 6.3 13/19] btrfs: fix an uninitialized variable warning in btrfs_log_inode
Date: Thu, 15 Jun 2023 07:37:13 -0400	[thread overview]
Message-ID: <20230615113719.648862-13-sashal@kernel.org> (raw)
In-Reply-To: <20230615113719.648862-1-sashal@kernel.org>

From: Shida Zhang <zhangshida@kylinos.cn>

[ Upstream commit 8fd9f4232d8152c650fd15127f533a0f6d0a4b2b ]

This fixes the following warning reported by gcc 10.2.1 under x86_64:

../fs/btrfs/tree-log.c: In function ‘btrfs_log_inode’:
../fs/btrfs/tree-log.c:6211:9: error: ‘last_range_start’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
 6211 |   ret = insert_dir_log_key(trans, log, path, key.objectid,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 6212 |       first_dir_index, last_dir_index);
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../fs/btrfs/tree-log.c:6161:6: note: ‘last_range_start’ was declared here
 6161 |  u64 last_range_start;
      |      ^~~~~~~~~~~~~~~~

This might be a false positive fixed in later compiler versions but we
want to have it fixed.

Reported-by: k2ci <kernel-bot@kylinos.cn>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/btrfs/tree-log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 200cea6e49e51..b91fa398b8141 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -6163,7 +6163,7 @@ static int log_delayed_deletions_incremental(struct btrfs_trans_handle *trans,
 {
 	struct btrfs_root *log = inode->root->log_root;
 	const struct btrfs_delayed_item *curr;
-	u64 last_range_start;
+	u64 last_range_start = 0;
 	u64 last_range_end = 0;
 	struct btrfs_key key;
 
-- 
2.39.2


  parent reply	other threads:[~2023-06-15 11:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 11:37 [PATCH AUTOSEL 6.3 01/19] regmap: Account for register length when chunking Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 02/19] iommu/amd: Handle GALog overflows Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 03/19] scsi: target: iscsi: Fix hang in the iSCSI login code Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 04/19] scsi: target: iscsi: Remove unused transport_timer Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 05/19] scsi: target: iscsi: Prevent login threads from racing between each other Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 06/19] HID: google: add jewel USB id Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 07/19] HID: wacom: Add error check to wacom_parse_and_register() Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 08/19] arm64: Add missing Set/Way CMO encodings Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 09/19] smb3: missing null check in SMB2_change_notify Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 10/19] media: cec: core: disable adapter in cec_devnode_unregister Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 11/19] media: cec: core: don't set last_initiator if tx in progress Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 12/19] nfcsim.c: Fix error checking for debugfs_create_dir Sasha Levin
2023-06-15 11:37 ` Sasha Levin [this message]
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 14/19] usb: gadget: udc: fix NULL dereference in remove() Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 15/19] nvme: fix miss command type check Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 16/19] nvme: double KA polling frequency to avoid KATO with TBKAS on Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 17/19] nvme: check IO start time when deciding to defer KA Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 18/19] ext4: enable the lazy init thread when remounting read/write Sasha Levin
2023-06-15 11:37 ` [PATCH AUTOSEL 6.3 19/19] nvme: improve handling of long keep alives Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615113719.648862-13-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=anand.jain@oracle.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=kernel-bot@kylinos.cn \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=zhangshida@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox