From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A0E3EB64D9 for ; Thu, 15 Jun 2023 11:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344327AbjFOLl7 (ORCPT ); Thu, 15 Jun 2023 07:41:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344266AbjFOLlV (ORCPT ); Thu, 15 Jun 2023 07:41:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32884203; Thu, 15 Jun 2023 04:39:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 92D38639F5; Thu, 15 Jun 2023 11:39:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 597EDC433C8; Thu, 15 Jun 2023 11:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686829154; bh=IT2ZpffyqEISnL6NLd+96omR6hfrvOlCcRzPt2a66jQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iw0dL7taTwAS0V0JdZ5zgtWGfyvROelxRpGswDZ9qy4nqK5jgJSZeLEyOa2iQOcFy WmgWGj41zZ3NDlDkV/R4mYwsjOuLHa+zYwBNkoUvNh6WRa7sj+rpUvN45V2Qbi5v+e dOI7a0GKM+jPrXyGzxe6+dFxje/VvJcYxO6SqR+Fm0i7xMViFQah5U/Y+sIlCa6+cu 3oscWVXx3RFLyC3pLE1fHfhcNyYc2KyIQnm7WmCr1hpEeTc2LlADxdirORjPd7FUBI pYOTExr6cDnBlqKh8kgmuBa3rRG3/4g4k66WB9G4IxJPZSbBo7Jw0yND2Gw4PTMKEE yc9DE+sdpxgxw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 08/10] usb: gadget: udc: fix NULL dereference in remove() Date: Thu, 15 Jun 2023 07:38:52 -0400 Message-Id: <20230615113854.649370-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615113854.649370-1-sashal@kernel.org> References: <20230615113854.649370-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.117 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 016da9c65fec9f0e78c4909ed9a0f2d567af6775 ] The "udc" pointer was never set in the probe() function so it will lead to a NULL dereference in udc_pci_remove() when we do: usb_del_gadget_udc(&udc->gadget); Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/ZG+A/dNpFWAlCChk@kili Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/amd5536udc_pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c index c80f9bd51b750..a36913ae31f9e 100644 --- a/drivers/usb/gadget/udc/amd5536udc_pci.c +++ b/drivers/usb/gadget/udc/amd5536udc_pci.c @@ -170,6 +170,9 @@ static int udc_pci_probe( retval = -ENODEV; goto err_probe; } + + udc = dev; + return 0; err_probe: -- 2.39.2