From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8163BEB64D9 for ; Thu, 15 Jun 2023 11:43:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344483AbjFOLng (ORCPT ); Thu, 15 Jun 2023 07:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344072AbjFOLmq (ORCPT ); Thu, 15 Jun 2023 07:42:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E17E3A8B; Thu, 15 Jun 2023 04:39:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E8866387F; Thu, 15 Jun 2023 11:39:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D19CC433CC; Thu, 15 Jun 2023 11:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686829195; bh=kOLsJa76zqfPuOfw8I5+PGjN1wLCPIKt8iink4QIXMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s2OUG2DKQa6bearD/Yg7ZPemy0QuLgcCLFix4o6GmKMjOo8FJ2LyeOre1pbJqf9EG sH8TT/gnYvrds5x+u7sGao4E5UkNF6mT5db01P9p4i9XpLWgn/IsWcA6+uLpRVYl6g xoaq5PCmkLTUu5C04+mBywh/Pz+UEjG5uZCA3BXE8SUKQ3dg41l/kieKG2xYG4Db8P m1UG7eZv/grhrgTHILKRtVfRxGGF8upr4GeCbYFKccvC6AAIJ+ehnipSH9Yw7sB9sV lTzk7f/EzkbpuAsbDiQ9uaALF9IDM/YfeQoiE3FE689OgvWDqNWE/bxShirAKvDmg9 EOrfUWuvUW0nw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 8/8] usb: gadget: udc: fix NULL dereference in remove() Date: Thu, 15 Jun 2023 07:39:38 -0400 Message-Id: <20230615113938.649627-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615113938.649627-1-sashal@kernel.org> References: <20230615113938.649627-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.247 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 016da9c65fec9f0e78c4909ed9a0f2d567af6775 ] The "udc" pointer was never set in the probe() function so it will lead to a NULL dereference in udc_pci_remove() when we do: usb_del_gadget_udc(&udc->gadget); Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/ZG+A/dNpFWAlCChk@kili Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/amd5536udc_pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c index 362284057d307..a3d15c3fb82a9 100644 --- a/drivers/usb/gadget/udc/amd5536udc_pci.c +++ b/drivers/usb/gadget/udc/amd5536udc_pci.c @@ -171,6 +171,9 @@ static int udc_pci_probe( retval = -ENODEV; goto err_probe; } + + udc = dev; + return 0; err_probe: -- 2.39.2