From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CC3EB64D9 for ; Thu, 15 Jun 2023 14:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344715AbjFOOFr (ORCPT ); Thu, 15 Jun 2023 10:05:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344704AbjFOOFo (ORCPT ); Thu, 15 Jun 2023 10:05:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC2BB107 for ; Thu, 15 Jun 2023 07:05:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48D3161D2E for ; Thu, 15 Jun 2023 14:05:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10069C433C0; Thu, 15 Jun 2023 14:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686837942; bh=pEsBk/1CX2xgWRPlvMgLiWhEWL+m3P52hV5LCf6LOGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eTEsYhfYEOcld0j8WfzIP4utqRbNs8yDiqyY5dj0hSSaUKQ1JOVEisxVY5FZmXHVo 3/tk4SZiAyV09edh7aXGlsovR0qSEQx6hbUswl0b8iYxxM/vEobIAg3BoUkGRI1eDP zazO+hlPBqfRE5oFrkjRrazvlRcT87jLwBO8K2+B108+vCEy0n1s/Whns08skUaExG djWWBaH/UDFv4WahFWutmssy1MZsxFYXM2+YaNQz3uyXNH2taN97D6DBUJ4RUVuLZ1 ZZNgCrs78wy59OiDp43ZCCTbYMpfi3SvWFQy+hePGJ2F/4WoBd9ddBonjK7Ex60MrS m1SG7IcSg1ecA== Date: Thu, 15 Jun 2023 15:05:37 +0100 From: Lee Jones To: Amelie Delaunay Cc: Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 1/2] mfd: stmfx: Fix error path in stmfx_chip_init Message-ID: <20230615140537.GF3635807@google.com> References: <20230609092804.793100-1-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230609092804.793100-1-amelie.delaunay@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Jun 2023, Amelie Delaunay wrote: > In error path, disable vdd regulator if it exists, but don't overload ret. > Because if regulator_disable() is successful, stmfx_chip_init will exit > successfully while chip init failed. > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Signed-off-by: Amelie Delaunay > --- > drivers/mfd/stmfx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]