* [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion
@ 2023-06-15 16:25 Andy Shevchenko
2023-06-15 18:56 ` Linus Walleij
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-06-15 16:25 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-arm-kernel, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko,
Vladimir Zapolskiy
The of_gpio.h is not and shouldn't be used in the GPIO drivers.
Remove it.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-lpc18xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c
index d711ae06747e..ed3f653a1dfc 100644
--- a/drivers/gpio/gpio-lpc18xx.c
+++ b/drivers/gpio/gpio-lpc18xx.c
@@ -14,7 +14,6 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
-#include <linux/of_gpio.h>
#include <linux/of_irq.h>
#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion
2023-06-15 16:25 [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion Andy Shevchenko
@ 2023-06-15 18:56 ` Linus Walleij
2023-06-15 23:37 ` Vladimir Zapolskiy
2023-06-19 12:45 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2023-06-15 18:56 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Bartosz Golaszewski,
Andy Shevchenko, Vladimir Zapolskiy
On Thu, Jun 15, 2023 at 6:25 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion
2023-06-15 16:25 [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion Andy Shevchenko
2023-06-15 18:56 ` Linus Walleij
@ 2023-06-15 23:37 ` Vladimir Zapolskiy
2023-06-19 12:45 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2023-06-15 23:37 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-arm-kernel, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko
On 6/15/23 19:25, Andy Shevchenko wrote:
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Thank you for the correct change.
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion
2023-06-15 16:25 [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion Andy Shevchenko
2023-06-15 18:56 ` Linus Walleij
2023-06-15 23:37 ` Vladimir Zapolskiy
@ 2023-06-19 12:45 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-06-19 12:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Linus Walleij,
Andy Shevchenko, Vladimir Zapolskiy
On Thu, Jun 15, 2023 at 6:25 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-lpc18xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c
> index d711ae06747e..ed3f653a1dfc 100644
> --- a/drivers/gpio/gpio-lpc18xx.c
> +++ b/drivers/gpio/gpio-lpc18xx.c
> @@ -14,7 +14,6 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_irq.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> --
> 2.40.0.1.gaa8946217a0b
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-19 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-15 16:25 [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion Andy Shevchenko
2023-06-15 18:56 ` Linus Walleij
2023-06-15 23:37 ` Vladimir Zapolskiy
2023-06-19 12:45 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox