Re: [v2 PATCH] crypto: api - Add __crypto_alloc_tfmgfp

Dmitry Safonov
2023-06-15T16:20:08Z

On 6/15/23 10:00, Herbert Xu wrote:
[..]
>
> Good catch. Though I'd rather add the gfp argument to a separate
> function because I'm in the process of replacing ciphers with
> something that uses the new crypto_types API.
>
> Once that happens ciphers will switch over to the normal cloning
> call and this can be removed.

LGTM, thanks!

>
> ---8<---
> Use it straight away in crypto_clone_cipher(), as that is not meant to
> sleep.
>
> Fixes: 51d8d6d0f4be ("crypto: cipher - Add crypto_clone_cipher")
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/crypto/api.c b/crypto/api.c
[..]

Thanks,
Dmitry