Re: [PATCH v7] usb: common: usb-conn-gpio: Set last role to unknown before initial detection

Prashanth K
2023-05-31T14:47:39Z

On 31-05-23 08:11 pm, Prashanth K wrote:
>
> diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> index 5aabdd7..6d880c4 100644
> --- a/drivers/usb/musb/jz4740.c
> +++ b/drivers/usb/musb/jz4740.c
> @@ -95,6 +95,8 @@ static int jz4740_musb_role_switch_set(struct usb_role_switch *sw,
> case USB_ROLE_HOST:
> atomic_notifier_call_chain(&phy->notifier, USB_EVENT_ID, phy);
> break;
> + default:
> + break;
> }
>
> return 0;
> diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c b/drivers/usb/roles/intel-xhci-usb-role-switch.c
> index 5c96e92..4d6a3dd 100644
> --- a/drivers/usb/roles/intel-xhci-usb-role-switch.c
> +++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c
> @@ -97,6 +97,8 @@ static int intel_xhci_usb_set_role(struct usb_role_switch *sw,
> val |= SW_VBUS_VALID;
> drd_config = DRD_CONFIG_STATIC_DEVICE;
> break;
> + default:
> + break;
> }
> val |= SW_IDPIN_EN;
> if (data->enable_sw_switch) {
> diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h
> index b5deafd..65e790a 100644
> --- a/include/linux/usb/role.h
> +++ b/include/linux/usb/role.h
> @@ -11,6 +11,7 @@ enum usb_role {
> USB_ROLE_NONE,
> USB_ROLE_HOST,
> USB_ROLE_DEVICE,
> + USB_ROLE_UNKNOWN,
> };
>
> typedef int (*usb_role_switch_set_t)(struct usb_role_switch *sw,

Hi Greg, I have fixed the drivers that doesn't have default case while
using usb_role enum. Added the same on intel-xhci-usb-role-switch.c &
musb/jz4740.c files. I was able to compile successfully. Please check
once if this fixed the build issue.

Thanks in advance,
Prashanth K