From: Alexander Potapenko <glider@google.com>
To: torvalds@linux-foundation.org
Cc: dave.hansen@linux.intel.com, kirill.shutemov@linux.intel.com,
linux-kernel@vger.kernel.org, peterz@infradead.org,
x86@kernel.org, Alexander Potapenko <glider@google.com>
Subject: Re: [GIT PULL] x86/mm for 6.4
Date: Fri, 16 Jun 2023 10:47:15 +0200 [thread overview]
Message-ID: <20230616084715.2140984-1-glider@google.com> (raw)
In-Reply-To: <CAHk-=wgrdOm8RwO+u8bydrbgs0wXJV_9mBYAtzX9d9hEY7a25A@mail.gmail.com>
Hi Linus,
> static bool ex_handler_uaccess(const struct exception_table_entry *fixup,
> - struct pt_regs *regs, int trapnr)
> + struct pt_regs *regs, int trapnr,
> + unsigned long fault_address)
> {
> - WARN_ONCE(trapnr == X86_TRAP_GP, "General protection fault in user access. Non-canonical address?");
> + WARN_ONCE(trapnr == X86_TRAP_GP && !gp_fault_address_ok(fault_address),
> + "General protection fault in user access. Non-canonical address?");
> return ex_handler_default(fixup, regs);
> }
Shouldn't ex_handler_copy() be fixed in the same way?
Looks like it's still possible for a tagged userspace address to be passed to it and trigger a warning.
Alex
next prev parent reply other threads:[~2023-06-16 8:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 22:56 [GIT PULL] x86/mm for 6.4 Dave Hansen
2023-04-28 17:23 ` pr-tracker-bot
2023-04-28 20:07 ` Linus Torvalds
2023-04-28 20:15 ` Linus Torvalds
2023-04-29 0:38 ` Kirill A. Shutemov
2023-04-29 1:04 ` Linus Torvalds
2023-05-02 15:42 ` Dave Hansen
2023-05-02 16:00 ` Linus Torvalds
2023-05-02 20:14 ` Linus Torvalds
2023-05-03 0:53 ` Dave Hansen
2023-05-03 1:17 ` Linus Torvalds
2023-05-03 16:38 ` Linus Torvalds
2023-05-03 16:44 ` Dave Hansen
2023-05-03 16:51 ` Linus Torvalds
2023-05-03 17:54 ` Linus Torvalds
2023-05-03 19:01 ` Peter Zijlstra
2023-05-03 19:19 ` Linus Torvalds
2023-05-05 19:56 ` Linus Torvalds
2023-05-05 20:59 ` Kirill A. Shutemov
2023-05-04 6:28 ` Kirill A. Shutemov
2023-05-04 15:25 ` Dave Hansen
2023-05-04 17:10 ` Kirill A. Shutemov
2023-05-04 17:10 ` Linus Torvalds
2023-05-03 8:01 ` Peter Zijlstra
2023-05-03 16:38 ` Linus Torvalds
2023-06-16 8:47 ` Alexander Potapenko [this message]
2023-06-16 16:22 ` Linus Torvalds
2023-06-19 12:03 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616084715.2140984-1-glider@google.com \
--to=glider@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox