public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Simon Horman <horms@kernel.org>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
	Wolfram Sang <wsa@kernel.org>, Sasha Levin <sashal@kernel.org>,
	kumaravel.thiagarajan@microchip.com,
	UNGLinuxDriver@microchip.com, nathan@kernel.org,
	ndesaulniers@google.com, linux-i2c@vger.kernel.org,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 6.1 17/26] i2c: mchp-pci1xxxx: Avoid cast to incompatible function type
Date: Fri, 16 Jun 2023 06:26:14 -0400	[thread overview]
Message-ID: <20230616102625.673454-17-sashal@kernel.org> (raw)
In-Reply-To: <20230616102625.673454-1-sashal@kernel.org>

From: Simon Horman <horms@kernel.org>

[ Upstream commit 7ebfd881abe9e0ea9557b29dab6aa28d294fabb4 ]

Rather than casting pci1xxxx_i2c_shutdown to an incompatible function type,
update the type to match that expected by __devm_add_action.

Reported by clang-16 with W-1:

 .../i2c-mchp-pci1xxxx.c:1159:29: error: cast from 'void (*)(struct pci1xxxx_i2c *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
         ret = devm_add_action(dev, (void (*)(void *))pci1xxxx_i2c_shutdown, i2c);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ./include/linux/device.h:251:29: note: expanded from macro 'devm_add_action'
         __devm_add_action(release, action, data, #action)
                                   ^~~~~~

No functional change intended.
Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Reviewed-by: Tharun Kumar P<tharunkumar.pasumarthi@microchip.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/i2c/busses/i2c-mchp-pci1xxxx.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-mchp-pci1xxxx.c b/drivers/i2c/busses/i2c-mchp-pci1xxxx.c
index b21ffd6df9276..5ef136c3ecb12 100644
--- a/drivers/i2c/busses/i2c-mchp-pci1xxxx.c
+++ b/drivers/i2c/busses/i2c-mchp-pci1xxxx.c
@@ -1118,8 +1118,10 @@ static int pci1xxxx_i2c_resume(struct device *dev)
 static DEFINE_SIMPLE_DEV_PM_OPS(pci1xxxx_i2c_pm_ops, pci1xxxx_i2c_suspend,
 			 pci1xxxx_i2c_resume);
 
-static void pci1xxxx_i2c_shutdown(struct pci1xxxx_i2c *i2c)
+static void pci1xxxx_i2c_shutdown(void *data)
 {
+	struct pci1xxxx_i2c *i2c = data;
+
 	pci1xxxx_i2c_config_padctrl(i2c, false);
 	pci1xxxx_i2c_configure_core_reg(i2c, false);
 }
@@ -1156,7 +1158,7 @@ static int pci1xxxx_i2c_probe_pci(struct pci_dev *pdev,
 	init_completion(&i2c->i2c_xfer_done);
 	pci1xxxx_i2c_init(i2c);
 
-	ret = devm_add_action(dev, (void (*)(void *))pci1xxxx_i2c_shutdown, i2c);
+	ret = devm_add_action(dev, pci1xxxx_i2c_shutdown, i2c);
 	if (ret)
 		return ret;
 
-- 
2.39.2


  parent reply	other threads:[~2023-06-16 10:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 10:25 [PATCH AUTOSEL 6.1 01/26] Input: soc_button_array - add invalid acpi_index DMI quirk handling Sasha Levin
2023-06-16 10:25 ` [PATCH AUTOSEL 6.1 02/26] arm64: dts: qcom: sc7280-idp: drop incorrect dai-cells from WCD938x SDW Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 03/26] arm64: dts: qcom: sc7280-qcard: " Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 04/26] s390/cio: unregister device when the only path is gone Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 05/26] spi: lpspi: disable lpspi module irq in DMA mode Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 06/26] ASoC: codecs: wcd938x-sdw: do not set can_multi_write flag Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 07/26] ASoC: simple-card: Add missing of_node_put() in case of error Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 08/26] soundwire: dmi-quirks: add new mapping for HP Spectre x360 Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 09/26] soundwire: qcom: add proper error paths in qcom_swrm_startup() Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 10/26] ASoC: nau8824: Add quirk to active-high jack-detect Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 11/26] ASoC: amd: yc: Add Thinkpad Neo14 to quirks list for acp6x Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 12/26] drm/ast: Fix modeset failed on DisplayPort Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 13/26] gfs2: Don't get stuck writing page onto itself under direct I/O Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 14/26] s390/purgatory: disable branch profiling Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 15/26] ASoC: fsl_sai: Enable BCI bit if SAI works on synchronous mode with BYP asserted Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 16/26] ALSA: hda/realtek: Add "Intel Reference board" and "NUC 13" SSID in the ALC256 Sasha Levin
2023-06-16 10:26 ` Sasha Levin [this message]
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 18/26] ARM: dts: Fix erroneous ADS touchscreen polarities Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 19/26] null_blk: Fix: memory release when memory_backed=1 Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 20/26] drm/exynos: vidi: fix a wrong error return Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 21/26] drm/exynos: fix race condition UAF in exynos_g2d_exec_ioctl Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 22/26] drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 23/26] Revert "ext4: don't clear SB_RDONLY when remounting r/w until quota is re-enabled" Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 24/26] ext4: only check dquot_initialize_needed() when debugging Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 25/26] vhost_vdpa: tell vqs about the negotiated Sasha Levin
2023-06-16 10:26 ` [PATCH AUTOSEL 6.1 26/26] vhost_net: revert upend_idx only on retriable error Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230616102625.673454-17-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andi.shyti@kernel.org \
    --cc=horatiu.vultur@microchip.com \
    --cc=horms@kernel.org \
    --cc=kumaravel.thiagarajan@microchip.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tharunkumar.pasumarthi@microchip.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox