Re: [PATCH 0/6] KVM: Documentation: Update document description for kvm_mmu_page and kvm_mmu_page_role

Mingwei Zhang
2023-06-21T18:34:22Z

On Mon, Jun 19, 2023 at 2:00 AM Zhi Wang <zhi.wang.linux@gmail.com> wrote:
>
> On Sun, 18 Jun 2023 00:08:50 +0000
> Mingwei Zhang <mizhang@google.com> wrote:
>
> > When reading the KVM MMU documentation for nested virtualization, I feel
> > that the description of kvm_mmu_page (and kvm_mmu_page_role) has been
> > lagging for around 1-2 years. The descriptions for several fields in struct
> > kvm_mmu_page and struct kvm_mmu_page_role are missing. So I think it might
> > be good to add them to make it consistent with the current code.
> >
>
> This is so nice. A trivial comment, maybe refining the tittle of PATCH 1-6 a
> bit: "Add the missing comment of xxxx into xxxx". It is a little bit confusing
> by just looking at the titles at the first glance, more like some members are
> missing, not the comments. :)
>

Sure. Yeah, the shortlog looks slightly confusing as if I am changing
the actual data structures. I will update those in the next version.
Thanks for your comments.

-Mingwei