* [PATCH] lib/test_printf.c: space required after that ',' [not found] <20230614082523.63191-1-panzhiai@cdjrlc.com> @ 2023-06-14 8:30 ` hexingwei001 2023-06-14 12:32 ` Andy Shevchenko 0 siblings, 1 reply; 7+ messages in thread From: hexingwei001 @ 2023-06-14 8:30 UTC (permalink / raw) To: pmladek, rostedt, senozhatsky; +Cc: linux-kernel, andriy.shevchenko, linux Add missing spaces to clear checkpatch errors: lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). Signed-off-by: Xingwei He <hexingwei001@208suo.com> --- lib/test_printf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_printf.c b/lib/test_printf.c index 7677ebccf3c3..9d17c564fdf6 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -559,7 +559,7 @@ static void __init bitmap(void) { DECLARE_BITMAP(bits, 20); - const int primes[] = {2,3,5,7,11,13,17,19}; + const int primes[] = {2, 3, 5, 7, 11, 13, 17, 19}; int i; bitmap_zero(bits, 20); ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] lib/test_printf.c: space required after that ',' 2023-06-14 8:30 ` [PATCH] lib/test_printf.c: space required after that ',' hexingwei001 @ 2023-06-14 12:32 ` Andy Shevchenko 2023-06-14 15:06 ` Steven Rostedt 0 siblings, 1 reply; 7+ messages in thread From: Andy Shevchenko @ 2023-06-14 12:32 UTC (permalink / raw) To: hexingwei001; +Cc: pmladek, rostedt, senozhatsky, linux-kernel, linux On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wrote: > Add missing spaces to clear checkpatch errors: > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). Doesn't make any difference to the code, so let do this (unneeded) churn to calm checkpatch down. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Xingwei He <hexingwei001@208suo.com> > --- > lib/test_printf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 7677ebccf3c3..9d17c564fdf6 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -559,7 +559,7 @@ static void __init > bitmap(void) > { > DECLARE_BITMAP(bits, 20); > - const int primes[] = {2,3,5,7,11,13,17,19}; > + const int primes[] = {2, 3, 5, 7, 11, 13, 17, 19}; > int i; > > bitmap_zero(bits, 20); -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib/test_printf.c: space required after that ',' 2023-06-14 12:32 ` Andy Shevchenko @ 2023-06-14 15:06 ` Steven Rostedt 2023-06-14 15:16 ` Andy Shevchenko 0 siblings, 1 reply; 7+ messages in thread From: Steven Rostedt @ 2023-06-14 15:06 UTC (permalink / raw) To: Andy Shevchenko; +Cc: hexingwei001, pmladek, senozhatsky, linux-kernel, linux On Wed, 14 Jun 2023 15:32:30 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wrote: > > Add missing spaces to clear checkpatch errors: > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > Doesn't make any difference to the code, so let do this (unneeded) churn > to calm checkpatch down. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> checkpatch is for patches (new code) and should not be run on existing code. -- Steve ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib/test_printf.c: space required after that ',' 2023-06-14 15:06 ` Steven Rostedt @ 2023-06-14 15:16 ` Andy Shevchenko 2023-06-18 3:55 ` Sergey Senozhatsky 2023-06-19 6:45 ` Pavel Machek 0 siblings, 2 replies; 7+ messages in thread From: Andy Shevchenko @ 2023-06-14 15:16 UTC (permalink / raw) To: Steven Rostedt; +Cc: hexingwei001, pmladek, senozhatsky, linux-kernel, linux On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote: > On Wed, 14 Jun 2023 15:32:30 +0300 > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wrote: > > > Add missing spaces to clear checkpatch errors: > > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > Doesn't make any difference to the code, so let do this (unneeded) churn > > to calm checkpatch down. > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > checkpatch is for patches (new code) and should not be run on existing code. Why does it have -f option? What do you propose to prevent people from using it? -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib/test_printf.c: space required after that ',' 2023-06-14 15:16 ` Andy Shevchenko @ 2023-06-18 3:55 ` Sergey Senozhatsky 2023-06-19 6:45 ` Pavel Machek 1 sibling, 0 replies; 7+ messages in thread From: Sergey Senozhatsky @ 2023-06-18 3:55 UTC (permalink / raw) To: Andy Shevchenko Cc: Steven Rostedt, hexingwei001, pmladek, senozhatsky, linux-kernel, linux On (23/06/14 18:16), Andy Shevchenko wrote: > > > > checkpatch is for patches (new code) and should not be run on existing code. > > What do you propose to prevent people from using it? Yes. It should not be used on the existing code because it breaks backport of important fixes to stable trees. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib/test_printf.c: space required after that ',' 2023-06-14 15:16 ` Andy Shevchenko 2023-06-18 3:55 ` Sergey Senozhatsky @ 2023-06-19 6:45 ` Pavel Machek 2023-06-19 13:20 ` Petr Mladek 1 sibling, 1 reply; 7+ messages in thread From: Pavel Machek @ 2023-06-19 6:45 UTC (permalink / raw) To: Andy Shevchenko Cc: Steven Rostedt, hexingwei001, pmladek, senozhatsky, linux-kernel, linux [-- Attachment #1: Type: text/plain, Size: 1485 bytes --] On Wed 2023-06-14 18:16:36, Andy Shevchenko wrote: > On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote: > > On Wed, 14 Jun 2023 15:32:30 +0300 > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wrote: > > > > Add missing spaces to clear checkpatch errors: > > > > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > > > Doesn't make any difference to the code, so let do this (unneeded) churn > > > to calm checkpatch down. > > > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > checkpatch is for patches (new code) and should not be run on existing code. > > Why does it have -f option? What do you propose to prevent people from using it? Brain needs to be used while using checkpatch. Plus, autosel is "great" trying to backport anything that mentions "error", so better don't do this. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib/test_printf.c: space required after that ',' 2023-06-19 6:45 ` Pavel Machek @ 2023-06-19 13:20 ` Petr Mladek 0 siblings, 0 replies; 7+ messages in thread From: Petr Mladek @ 2023-06-19 13:20 UTC (permalink / raw) To: Pavel Machek Cc: Andy Shevchenko, Steven Rostedt, hexingwei001, senozhatsky, linux-kernel, linux On Mon 2023-06-19 08:45:22, Pavel Machek wrote: > On Wed 2023-06-14 18:16:36, Andy Shevchenko wrote: > > On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote: > > > On Wed, 14 Jun 2023 15:32:30 +0300 > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wrote: > > > > > Add missing spaces to clear checkpatch errors: > > > > > > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV). > > > > > > > > Doesn't make any difference to the code, so let do this (unneeded) churn > > > > to calm checkpatch down. > > > > > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > checkpatch is for patches (new code) and should not be run on existing code. > > > > Why does it have -f option? What do you propose to prevent people from using it? > > Brain needs to be used while using checkpatch. I agree. Also I agree with Sergey that these changes just complicate backport. I would prefer if people did not send these cosmetic "fixes". > Plus, autosel is "great" trying to backport anything that mentions > "error", so better don't do this. Autosel is another tool which would deserve a human filter. Well, we have it because of lack of resources... I am surprised that checkpatch.po reports the missing space as an "ERROR" in the first place. Best Regards, Petr ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-19 13:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230614082523.63191-1-panzhiai@cdjrlc.com>
2023-06-14 8:30 ` [PATCH] lib/test_printf.c: space required after that ',' hexingwei001
2023-06-14 12:32 ` Andy Shevchenko
2023-06-14 15:06 ` Steven Rostedt
2023-06-14 15:16 ` Andy Shevchenko
2023-06-18 3:55 ` Sergey Senozhatsky
2023-06-19 6:45 ` Pavel Machek
2023-06-19 13:20 ` Petr Mladek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox