From: Lee Jones <lee@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: rsmu: turn rsmu-{core,i2c,spi} into single-object modules
Date: Mon, 19 Jun 2023 09:33:33 +0100 [thread overview]
Message-ID: <20230619083333.GQ3635807@google.com> (raw)
In-Reply-To: <CAK7LNAQjYQSMjNb4Cn_8NVxGhsJ96-JBeNChVzLjefQZ82aKVg@mail.gmail.com>
On Fri, 16 Jun 2023, Masahiro Yamada wrote:
> On Thu, Jun 15, 2023 at 11:00 PM Lee Jones <lee@kernel.org> wrote:
> >
> > On Sun, 04 Jun 2023, Masahiro Yamada wrote:
> >
> > > With the previous fix, these modules are built from a single C file.
> > >
> > > Rename the source files so they match the module names.
> >
> > Should this be part of the previous patch?
>
>
> I do not know. It is up to the maintainer's preference (you).
>
> If you want me to send a squashed patch, I will be
> happy to do so.
I think it makes sense in this case.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-06-19 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 4:25 [PATCH 1/2] mfd: rsmu: fix mixed module-builtin object Masahiro Yamada
2023-06-04 4:25 ` [PATCH 2/2] mfd: rsmu: turn rsmu-{core,i2c,spi} into single-object modules Masahiro Yamada
2023-06-15 14:00 ` Lee Jones
2023-06-16 5:03 ` Masahiro Yamada
2023-06-19 8:33 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619083333.GQ3635807@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox