Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

Arnd Bergmann
2023-03-21T08:32:41Z

On Sun, Mar 12, 2023, at 14:13, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:
> ‘mtk8195_jpegdec_drvdata’ defined but not used
> [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I see now that we both submitted the same patch, but now Hans
merged a worse fix [1] without a changelog text.

Arnd