Re: [PATCH 23/28] media: i2c: ov2640: drop of_match_ptr for ID table

Laurent Pinchart
2023-03-12T13:44:52Z

Hi Krzysztof,

Thank you for the patch.

On Sun, Mar 12, 2023 at 02:13:13PM +0100, Krzysztof Kozlowski wrote:
> The driver will match mostly by DT table (even thought there is regular
> ID table) so there is little benefit in of_match_ptr (this also allows
> ACPI matching via PRP0001, even though it might not be relevant here).
> This also fixes !CONFIG_OF error:
>
> drivers/media/i2c/ov2640.c:1290:34: error: ‘ov2640_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/media/i2c/ov2640.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c
> index 39d56838a4ef..a92c091356c5 100644
> --- a/drivers/media/i2c/ov2640.c
> +++ b/drivers/media/i2c/ov2640.c
> @@ -1296,7 +1296,7 @@ MODULE_DEVICE_TABLE(of, ov2640_of_match);
> static struct i2c_driver ov2640_i2c_driver = {
> .driver = {
> .name = "ov2640",
> - .of_match_table = of_match_ptr(ov2640_of_match),
> + .of_match_table = ov2640_of_match,
> },
> .probe_new = ov2640_probe,
> .remove = ov2640_remove,

--
Regards,

Laurent Pinchart