Re: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table

Krzysztof Kozlowski
2023-06-19T14:14:05Z

On 25/05/2023 15:19, Sakari Ailus wrote:
> Hi folks,
>
> On Thu, May 25, 2023 at 03:40:04PM +0300, Sakari Ailus wrote:
>> Hi Hans,
>>
>> On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote:
>>> On 12/05/2023 18:35, Krzysztof Kozlowski wrote:
>>>> On 12/03/2023 14:12, Krzysztof Kozlowski wrote:
>>>>> The driver can match only via the DT table so the table should be always
>>>>> used and the of_match_ptr does not have any sense (this also allows ACPI
>>>>> matching via PRP0001, even though it might not be relevant here).
>>>>>
>>>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>> ---
>>>>
>>>> Hans, Sakari,
>>>>
>>>> Can you pick up the patchset? There was positive feedback:
>>>> https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/
>>>>
>>>> but it seems it was not applied.
>>>
>>> I see it is delegated to Sakari in patchwork and marked Under Review, but I don't
>>> see a corresponding pull request for this series.
>>>
>>> Sakari, did something go wrong?
>>
>> I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for
>> this --- I intended to take these but I think I must have missed something
>> important in the process. I'll take them now.
>>
>> Thanks.
>
> This no longer applied cleanly. Mostly there was fuzz near .of_match_table
> changes as probe_new (and remove_new?) changes have been recently merged.
> There were other issues as well, I marked a few patches in the set "not
> applicable" as other patches had already done equivalent changes earlier.
>
> There were substance-changing changes in the 20th patch, replied to the
> disuccsion there.
>
> I've pushed the result here and intend to send PR to Mauro soon if there
> are no issues:
>
> <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr>

One month later, I still don't see this set in the linux-next. What's
happening here?

Best regards,
Krzysztof