Re: [PATCH 06/28] media: rc: ir-rx51: drop of_match_ptr for ID table

Sean Young
2023-03-13T14:55:50Z

On Sun, Mar 12, 2023 at 02:12:56PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/media/rc/ir-rx51.c:264:34: error: ‘ir_rx51_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Sean Young <sean@mess.org>

Thanks
Sean

> ---
> drivers/media/rc/ir-rx51.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c
> index adbbe639a261..13e81bf8005d 100644
> --- a/drivers/media/rc/ir-rx51.c
> +++ b/drivers/media/rc/ir-rx51.c
> @@ -275,7 +275,7 @@ static struct platform_driver ir_rx51_platform_driver = {
> .resume = ir_rx51_resume,
> .driver = {
> .name = KBUILD_MODNAME,
> - .of_match_table = of_match_ptr(ir_rx51_match),
> + .of_match_table = ir_rx51_match,
> },
> };
> module_platform_driver(ir_rx51_platform_driver);
> --
> 2.34.1