Re: [PATCH 16/28] media: platform: sun6i-csi: drop of_match_ptr for ID table

Jernej Škrabec
2023-03-14T19:52:02Z

Dne nedelja, 12. marec 2023 ob 14:13:06 CET je Krzysztof Kozlowski napisal(a):
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:401:34: error:
> ‘sun6i_csi_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index
> e3e6650181c8..187a2419da96 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> @@ -429,7 +429,7 @@ static struct platform_driver sun6i_csi_platform_driver
> = { .remove = sun6i_csi_remove,
> .driver = {
> .name = SUN6I_CSI_NAME,
> - .of_match_table =
of_match_ptr(sun6i_csi_of_match),
> + .of_match_table = sun6i_csi_of_match,
> .pm = &sun6i_csi_pm_ops,
> },
> };