Re: [PATCH 11/28] media: platform: ti: am437x: drop of_match_ptr for ID table

Laurent Pinchart
2023-03-12T13:43:59Z

Hi Krzysztof,

Thank you for the patch.

On Sun, Mar 12, 2023 at 02:13:01PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This

"might not be relevant" is a bit of an understatement in this case :-)

> also fixes !CONFIG_OF error:
>
> drivers/media/platform/ti/am437x/am437x-vpfe.c:2620:34: error: ‘vpfe_of_match’ defined but not used [-Werror=unused-const-variable=]

This driver should probably depend on CONFIG_OF, but that's a separate
issue.

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/media/platform/ti/am437x/am437x-vpfe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti/am437x/am437x-vpfe.c b/drivers/media/platform/ti/am437x/am437x-vpfe.c
> index 2dfae9bc0bba..fe89b8e250e7 100644
> --- a/drivers/media/platform/ti/am437x/am437x-vpfe.c
> +++ b/drivers/media/platform/ti/am437x/am437x-vpfe.c
> @@ -2629,7 +2629,7 @@ static struct platform_driver vpfe_driver = {
> .driver = {
> .name = VPFE_MODULE_NAME,
> .pm = &vpfe_pm_ops,
> - .of_match_table = of_match_ptr(vpfe_of_match),
> + .of_match_table = vpfe_of_match,
> },
> };
>

--
Regards,

Laurent Pinchart