Re: [PATCH 02/28] media: cec: meson: drop of_match_ptr for ID table

Hans Verkuil
2023-03-13T11:47:33Z

On 12/03/2023 14:12, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
> drivers/media/cec/platform/meson/ao-cec.c:711:34: error: ‘meson_ao_cec_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Thanks!

Hans

> ---
> drivers/media/cec/platform/meson/ao-cec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/cec/platform/meson/ao-cec.c b/drivers/media/cec/platform/meson/ao-cec.c
> index 6b440f0635d9..223c092dbb6a 100644
> --- a/drivers/media/cec/platform/meson/ao-cec.c
> +++ b/drivers/media/cec/platform/meson/ao-cec.c
> @@ -719,7 +719,7 @@ static struct platform_driver meson_ao_cec_driver = {
> .remove = meson_ao_cec_remove,
> .driver = {
> .name = "meson-ao-cec",
> - .of_match_table = of_match_ptr(meson_ao_cec_of_match),
> + .of_match_table = meson_ao_cec_of_match,
> },
> };
>