Re: [PATCH 04/28] media: rc: gpio-ir-recv: drop of_match_ptr for ID table

Sean Young
2023-03-13T14:56:02Z

On Sun, Mar 12, 2023 at 02:12:54PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/media/rc/gpio-ir-recv.c:197:34: error: ‘gpio_ir_recv_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Sean Young <sean@mess.org>

Thanks
Sean

> ---
> drivers/media/rc/gpio-ir-recv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
> index 8dbe780dae4e..ae1199cc73fd 100644
> --- a/drivers/media/rc/gpio-ir-recv.c
> +++ b/drivers/media/rc/gpio-ir-recv.c
> @@ -205,7 +205,7 @@ static struct platform_driver gpio_ir_recv_driver = {
> .remove = gpio_ir_recv_remove,
> .driver = {
> .name = KBUILD_MODNAME,
> - .of_match_table = of_match_ptr(gpio_ir_recv_of_match),
> + .of_match_table = gpio_ir_recv_of_match,
> #ifdef CONFIG_PM
> .pm = &gpio_ir_recv_pm_ops,
> #endif
> --
> 2.34.1