Re: [PATCH 09/28] media: platform: samsung: s5p-jpeg: drop of_match_ptr for ID table

Andrzej Pietrasiewicz
2023-03-13T17:10:42Z

Hi,

W dniu 12.03.2023 o 14:12, Krzysztof Kozlowski pisze:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:3124:34: error: ‘samsung_jpeg_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>

> ---
> drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> index 55814041b8d8..8be8e3596e07 100644
> --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> @@ -3166,7 +3166,7 @@ static struct platform_driver s5p_jpeg_driver = {
> .probe = s5p_jpeg_probe,
> .remove = s5p_jpeg_remove,
> .driver = {
> - .of_match_table = of_match_ptr(samsung_jpeg_match),
> + .of_match_table = samsung_jpeg_match,
> .name = S5P_JPEG_M2M_NAME,
> .pm = &s5p_jpeg_pm_ops,
> },