Re: [PATCH 07/28] media: platform: allegro-dvt: drop of_match_ptr for ID table

Michael Tretter
2023-03-13T14:58:09Z

On Sun, 12 Mar 2023 14:12:57 +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/media/platform/allegro-dvt/allegro-core.c:3995:34: error: ‘allegro_dt_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>

> ---
> drivers/media/platform/allegro-dvt/allegro-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/allegro-core.c
> index 2423714afcb9..7fc197a02cc2 100644
> --- a/drivers/media/platform/allegro-dvt/allegro-core.c
> +++ b/drivers/media/platform/allegro-dvt/allegro-core.c
> @@ -4009,7 +4009,7 @@ static struct platform_driver allegro_driver = {
> .remove = allegro_remove,
> .driver = {
> .name = "allegro",
> - .of_match_table = of_match_ptr(allegro_dt_ids),
> + .of_match_table = allegro_dt_ids,
> .pm = &allegro_pm_ops,
> },
> };
> --
> 2.34.1
>
>