From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
Xiubo Li <xiubli@redhat.com>, Ilya Dryomov <idryomov@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 17/79] ceph: switch to new ctime accessors
Date: Wed, 21 Jun 2023 10:45:30 -0400 [thread overview]
Message-ID: <20230621144735.55953-16-jlayton@kernel.org> (raw)
In-Reply-To: <20230621144735.55953-1-jlayton@kernel.org>
In later patches, we're going to change how the ctime.tv_nsec field is
utilized. Switch to using accessor functions instead of raw accesses of
inode->i_ctime.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/ceph/acl.c | 2 +-
fs/ceph/caps.c | 2 +-
fs/ceph/inode.c | 17 ++++++++++-------
fs/ceph/snap.c | 2 +-
fs/ceph/xattr.c | 2 +-
5 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c
index 6945a938d396..a3de2b9c3a68 100644
--- a/fs/ceph/acl.c
+++ b/fs/ceph/acl.c
@@ -93,7 +93,7 @@ int ceph_set_acl(struct mnt_idmap *idmap, struct dentry *dentry,
char *value = NULL;
struct iattr newattrs;
struct inode *inode = d_inode(dentry);
- struct timespec64 old_ctime = inode->i_ctime;
+ struct timespec64 old_ctime = inode_ctime_peek(inode);
umode_t new_mode = inode->i_mode, old_mode = inode->i_mode;
if (ceph_snap(inode) != CEPH_NOSNAP) {
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 2321e5ddb664..c144a07e334e 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -1400,7 +1400,7 @@ static void __prep_cap(struct cap_msg_args *arg, struct ceph_cap *cap,
arg->mtime = inode->i_mtime;
arg->atime = inode->i_atime;
- arg->ctime = inode->i_ctime;
+ arg->ctime = inode_ctime_peek(inode);
arg->btime = ci->i_btime;
arg->change_attr = inode_peek_iversion_raw(inode);
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index 8e5f41d45283..f0b3b11d695e 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -100,7 +100,7 @@ struct inode *ceph_get_snapdir(struct inode *parent)
inode->i_uid = parent->i_uid;
inode->i_gid = parent->i_gid;
inode->i_mtime = parent->i_mtime;
- inode->i_ctime = parent->i_ctime;
+ inode_ctime_set(inode, inode_ctime_peek(parent));
inode->i_atime = parent->i_atime;
ci->i_rbytes = 0;
ci->i_btime = ceph_inode(parent)->i_btime;
@@ -695,12 +695,14 @@ void ceph_fill_file_time(struct inode *inode, int issued,
CEPH_CAP_FILE_BUFFER|
CEPH_CAP_AUTH_EXCL|
CEPH_CAP_XATTR_EXCL)) {
+ struct timespec64 ictime = inode_ctime_peek(inode);
+
if (ci->i_version == 0 ||
- timespec64_compare(ctime, &inode->i_ctime) > 0) {
+ timespec64_compare(ctime, &ictime) > 0) {
dout("ctime %lld.%09ld -> %lld.%09ld inc w/ cap\n",
- inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec,
+ ictime.tv_sec, ictime.tv_nsec,
ctime->tv_sec, ctime->tv_nsec);
- inode->i_ctime = *ctime;
+ inode_ctime_set(inode, *ctime);
}
if (ci->i_version == 0 ||
ceph_seq_cmp(time_warp_seq, ci->i_time_warp_seq) > 0) {
@@ -738,7 +740,7 @@ void ceph_fill_file_time(struct inode *inode, int issued,
} else {
/* we have no write|excl caps; whatever the MDS says is true */
if (ceph_seq_cmp(time_warp_seq, ci->i_time_warp_seq) >= 0) {
- inode->i_ctime = *ctime;
+ inode_ctime_set(inode, *ctime);
inode->i_mtime = *mtime;
inode->i_atime = *atime;
ci->i_time_warp_seq = time_warp_seq;
@@ -2166,7 +2168,8 @@ int __ceph_setattr(struct inode *inode, struct iattr *attr)
bool only = (ia_valid & (ATTR_SIZE|ATTR_MTIME|ATTR_ATIME|
ATTR_MODE|ATTR_UID|ATTR_GID)) == 0;
dout("setattr %p ctime %lld.%ld -> %lld.%ld (%s)\n", inode,
- inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec,
+ inode_ctime_peek(inode).tv_sec,
+ inode_ctime_peek(inode).tv_nsec,
attr->ia_ctime.tv_sec, attr->ia_ctime.tv_nsec,
only ? "ctime only" : "ignored");
if (only) {
@@ -2191,7 +2194,7 @@ int __ceph_setattr(struct inode *inode, struct iattr *attr)
if (dirtied) {
inode_dirty_flags = __ceph_mark_dirty_caps(ci, dirtied,
&prealloc_cf);
- inode->i_ctime = attr->ia_ctime;
+ inode_ctime_set(inode, attr->ia_ctime);
inode_inc_iversion_raw(inode);
}
diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c
index 2e73ba62bd7a..f02df070fa84 100644
--- a/fs/ceph/snap.c
+++ b/fs/ceph/snap.c
@@ -660,7 +660,7 @@ int __ceph_finish_cap_snap(struct ceph_inode_info *ci,
capsnap->size = i_size_read(inode);
capsnap->mtime = inode->i_mtime;
capsnap->atime = inode->i_atime;
- capsnap->ctime = inode->i_ctime;
+ capsnap->ctime = inode_ctime_peek(inode);
capsnap->btime = ci->i_btime;
capsnap->change_attr = inode_peek_iversion_raw(inode);
capsnap->time_warp_seq = ci->i_time_warp_seq;
diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
index 806183959c47..8e217f7f58bd 100644
--- a/fs/ceph/xattr.c
+++ b/fs/ceph/xattr.c
@@ -1238,7 +1238,7 @@ int __ceph_setxattr(struct inode *inode, const char *name,
dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_XATTR_EXCL,
&prealloc_cf);
ci->i_xattrs.dirty = true;
- inode->i_ctime = current_time(inode);
+ inode_ctime_set_current(inode);
}
spin_unlock(&ci->i_ceph_lock);
--
2.41.0
next prev parent reply other threads:[~2023-06-21 14:50 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230621144507.55591-1-jlayton@kernel.org>
2023-06-21 14:45 ` [PATCH 02/79] spufs: switch to new ctime accessors Jeff Layton
2023-06-21 14:45 ` [PATCH 03/79] s390: " Jeff Layton
2023-06-21 16:34 ` Jan Kara
2023-06-22 17:35 ` Alexander Gordeev
2023-06-22 17:51 ` Jeff Layton
2023-06-22 18:22 ` Alexander Gordeev
2023-06-22 18:46 ` Jeff Layton
2023-06-21 14:45 ` [PATCH 04/79] binderfs: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:35 ` Jan Kara
2023-06-21 14:45 ` [PATCH 05/79] qib_fs: " Jeff Layton
2023-06-21 16:35 ` Jan Kara
2023-06-21 19:37 ` Dennis Dalessandro
2023-06-21 14:45 ` [PATCH 06/79] ibm: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:35 ` Jan Kara
2023-06-21 14:45 ` [PATCH 07/79] usb: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:36 ` Jan Kara
2023-06-21 14:45 ` [PATCH 08/79] 9p: " Jeff Layton
2023-06-21 16:37 ` Jan Kara
2023-06-21 14:45 ` [PATCH 09/79] adfs: " Jeff Layton
2023-06-21 16:38 ` Jan Kara
2023-06-21 14:45 ` [PATCH 10/79] affs: " Jeff Layton
2023-06-21 16:39 ` Jan Kara
2023-06-22 11:37 ` David Sterba
2023-06-21 14:45 ` [PATCH 11/79] afs: " Jeff Layton
2023-06-21 16:43 ` Jan Kara
2023-06-21 14:45 ` [PATCH 12/79] fs: " Jeff Layton
2023-06-21 16:42 ` Jan Kara
2023-06-21 14:45 ` [PATCH 13/79] autofs: " Jeff Layton
2023-06-21 16:43 ` Jan Kara
2023-06-27 1:48 ` Ian Kent
2023-06-21 14:45 ` [PATCH 14/79] befs: " Jeff Layton
2023-06-21 16:44 ` Jan Kara
2023-06-21 14:45 ` [PATCH 15/79] bfs: " Jeff Layton
2023-06-21 16:48 ` Jan Kara
2023-06-21 16:57 ` Jeff Layton
2023-06-22 12:30 ` Jan Kara
2023-06-22 12:51 ` Jeff Layton
2023-06-22 14:57 ` Jan Kara
2023-06-23 12:33 ` Christian Brauner
2023-07-03 10:12 ` Christian Brauner
2023-07-03 10:46 ` Jeff Layton
2023-07-03 10:57 ` Christian Brauner
2023-06-21 14:45 ` [PATCH 16/79] btrfs: " Jeff Layton
2023-06-22 11:42 ` David Sterba
2023-06-21 14:45 ` Jeff Layton [this message]
2023-06-26 0:56 ` [PATCH 17/79] ceph: " Xiubo Li
2023-06-21 14:45 ` [PATCH 18/79] coda: " Jeff Layton
2023-06-21 14:45 ` [PATCH 19/79] configfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 20/79] cramfs: " Jeff Layton
2023-06-21 15:29 ` Nicolas Pitre
2023-06-21 14:45 ` [PATCH 21/79] debugfs: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 14:45 ` [PATCH 22/79] devpts: " Jeff Layton
2023-06-21 14:45 ` [PATCH 23/79] ecryptfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 24/79] efivarfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 25/79] efs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 26/79] erofs: " Jeff Layton
2023-06-22 4:01 ` Gao Xiang
2023-06-21 14:45 ` [PATCH 27/79] exfat: " Jeff Layton
2023-06-21 14:45 ` [PATCH 28/79] ext2: " Jeff Layton
2023-06-21 14:45 ` [PATCH 29/79] ext4: " Jeff Layton
2023-06-21 14:45 ` [PATCH 30/79] f2fs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 31/79] fat: " Jeff Layton
2023-06-21 14:45 ` [PATCH 32/79] freevxfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 33/79] fuse: " Jeff Layton
2023-06-21 14:45 ` [PATCH 34/79] gfs2: " Jeff Layton
2023-06-21 14:45 ` [PATCH 35/79] hfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 36/79] hfsplus: " Jeff Layton
2023-06-21 14:45 ` [PATCH 37/79] hostfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 38/79] hpfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 39/79] hugetlbfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 40/79] isofs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 41/79] jffs2: " Jeff Layton
2023-06-21 14:45 ` [PATCH 42/79] jfs: " Jeff Layton
2023-06-21 17:47 ` Dave Kleikamp
2023-06-21 14:45 ` [PATCH 43/79] kernfs: " Jeff Layton
2023-06-21 15:30 ` Greg Kroah-Hartman
2023-06-21 14:45 ` [PATCH 44/79] minix: " Jeff Layton
2023-06-21 14:45 ` [PATCH 45/79] nfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 46/79] nfsd: " Jeff Layton
2023-06-21 17:36 ` Chuck Lever
2023-06-21 14:46 ` [PATCH 47/79] nilfs2: " Jeff Layton
2023-06-26 15:26 ` Ryusuke Konishi
2023-06-21 14:46 ` [PATCH 48/79] ntfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 49/79] ntfs3: " Jeff Layton
2023-06-21 14:46 ` [PATCH 50/79] ocfs2: " Jeff Layton
2023-06-21 14:46 ` [PATCH 51/79] omfs: " Jeff Layton
2023-06-23 12:12 ` Bob Copeland
2023-06-21 14:46 ` [PATCH 52/79] openpromfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 53/79] orangefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 54/79] overlayfs: " Jeff Layton
2023-06-22 6:44 ` Amir Goldstein
2023-06-21 14:46 ` [PATCH 55/79] proc: " Jeff Layton
2023-06-30 22:13 ` Luis Chamberlain
2023-06-21 14:46 ` [PATCH 56/79] pstore: " Jeff Layton
2023-06-21 17:50 ` Kees Cook
2023-06-21 14:46 ` [PATCH 57/79] qnx4: " Jeff Layton
2023-06-23 14:26 ` Anders Larsen
2023-06-21 14:46 ` [PATCH 58/79] qnx6: " Jeff Layton
2023-06-21 14:46 ` [PATCH 59/79] ramfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 60/79] reiserfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 61/79] romfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 62/79] smb: " Jeff Layton
2023-06-21 17:45 ` Tom Talpey
2023-06-23 5:03 ` Sergey Senozhatsky
2023-06-21 14:46 ` [PATCH 63/79] squashfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 64/79] sysv: " Jeff Layton
2023-06-21 14:46 ` [PATCH 65/79] tracefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 66/79] ubifs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 67/79] udf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 68/79] ufs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 69/79] vboxsf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 70/79] xfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 71/79] zonefs: " Jeff Layton
2023-06-22 0:48 ` Damien Le Moal
2023-06-21 14:46 ` [PATCH 72/79] mqueue: " Jeff Layton
2023-06-21 14:46 ` [PATCH 73/79] bpf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 74/79] shmem: " Jeff Layton
2023-06-21 14:46 ` [PATCH 75/79] rpc_pipefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 76/79] apparmor: " Jeff Layton
2023-06-22 9:04 ` John Johansen
2023-06-21 14:46 ` [PATCH 77/79] security: " Jeff Layton
2023-06-23 14:15 ` Paul Moore
2023-06-21 14:46 ` [PATCH 78/79] selinux: " Jeff Layton
2023-06-23 14:17 ` Paul Moore
2023-06-21 16:34 ` [PATCH 02/79] spufs: " Jan Kara
2023-06-22 0:19 ` Jeremy Kerr
[not found] ` <20230621152141.5961cf5f@gandalf.local.home>
[not found] ` <2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org>
2023-06-23 12:41 ` [PATCH 00/79] fs: new accessors for inode->i_ctime Christian Brauner
2023-06-30 22:11 ` Luis Chamberlain
[not found] ` <20230621144507.55591-2-jlayton@kernel.org>
[not found] ` <99b3c749-23d9-6f09-fb75-6a84f3d1b066@kernel.org>
2023-06-22 10:14 ` [PATCH 01/79] fs: add ctime accessors infrastructure Jeff Layton
2023-06-30 22:12 ` Luis Chamberlain
2023-07-12 15:31 ` Randy Dunlap
2023-07-12 15:34 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621144735.55953-16-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox