From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 36/79] hfsplus: switch to new ctime accessors
Date: Wed, 21 Jun 2023 10:45:49 -0400 [thread overview]
Message-ID: <20230621144735.55953-35-jlayton@kernel.org> (raw)
In-Reply-To: <20230621144735.55953-1-jlayton@kernel.org>
In later patches, we're going to change how the ctime.tv_nsec field is
utilized. Switch to using accessor functions instead of raw accesses of
inode->i_ctime.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/hfsplus/catalog.c | 8 ++++----
fs/hfsplus/dir.c | 6 +++---
fs/hfsplus/inode.c | 14 +++++++-------
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/fs/hfsplus/catalog.c b/fs/hfsplus/catalog.c
index 35472cba750e..0e1938729669 100644
--- a/fs/hfsplus/catalog.c
+++ b/fs/hfsplus/catalog.c
@@ -312,7 +312,7 @@ int hfsplus_create_cat(u32 cnid, struct inode *dir,
dir->i_size++;
if (S_ISDIR(inode->i_mode))
hfsplus_subfolders_inc(dir);
- dir->i_mtime = dir->i_ctime = current_time(dir);
+ dir->i_mtime = inode_ctime_set_current(dir);
hfsplus_mark_inode_dirty(dir, HFSPLUS_I_CAT_DIRTY);
hfs_find_exit(&fd);
@@ -417,7 +417,7 @@ int hfsplus_delete_cat(u32 cnid, struct inode *dir, const struct qstr *str)
dir->i_size--;
if (type == HFSPLUS_FOLDER)
hfsplus_subfolders_dec(dir);
- dir->i_mtime = dir->i_ctime = current_time(dir);
+ dir->i_mtime = inode_ctime_set_current(dir);
hfsplus_mark_inode_dirty(dir, HFSPLUS_I_CAT_DIRTY);
if (type == HFSPLUS_FILE || type == HFSPLUS_FOLDER) {
@@ -494,7 +494,7 @@ int hfsplus_rename_cat(u32 cnid,
dst_dir->i_size++;
if (type == HFSPLUS_FOLDER)
hfsplus_subfolders_inc(dst_dir);
- dst_dir->i_mtime = dst_dir->i_ctime = current_time(dst_dir);
+ dst_dir->i_mtime = inode_ctime_set_current(dst_dir);
/* finally remove the old entry */
err = hfsplus_cat_build_key(sb, src_fd.search_key,
@@ -511,7 +511,7 @@ int hfsplus_rename_cat(u32 cnid,
src_dir->i_size--;
if (type == HFSPLUS_FOLDER)
hfsplus_subfolders_dec(src_dir);
- src_dir->i_mtime = src_dir->i_ctime = current_time(src_dir);
+ src_dir->i_mtime = inode_ctime_set_current(src_dir);
/* remove old thread entry */
hfsplus_cat_build_key_with_cnid(sb, src_fd.search_key, cnid);
diff --git a/fs/hfsplus/dir.c b/fs/hfsplus/dir.c
index 56fb5f1312e7..e7b6de12ecef 100644
--- a/fs/hfsplus/dir.c
+++ b/fs/hfsplus/dir.c
@@ -346,7 +346,7 @@ static int hfsplus_link(struct dentry *src_dentry, struct inode *dst_dir,
inc_nlink(inode);
hfsplus_instantiate(dst_dentry, inode, cnid);
ihold(inode);
- inode->i_ctime = current_time(inode);
+ inode_ctime_set_current(inode);
mark_inode_dirty(inode);
sbi->file_count++;
hfsplus_mark_mdb_dirty(dst_dir->i_sb);
@@ -405,7 +405,7 @@ static int hfsplus_unlink(struct inode *dir, struct dentry *dentry)
hfsplus_delete_inode(inode);
} else
sbi->file_count--;
- inode->i_ctime = current_time(inode);
+ inode_ctime_set_current(inode);
mark_inode_dirty(inode);
out:
mutex_unlock(&sbi->vh_mutex);
@@ -426,7 +426,7 @@ static int hfsplus_rmdir(struct inode *dir, struct dentry *dentry)
if (res)
goto out;
clear_nlink(inode);
- inode->i_ctime = current_time(inode);
+ inode_ctime_set_current(inode);
hfsplus_delete_inode(inode);
mark_inode_dirty(inode);
out:
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
index 7d1a675e037d..b9c02df839c8 100644
--- a/fs/hfsplus/inode.c
+++ b/fs/hfsplus/inode.c
@@ -267,7 +267,7 @@ static int hfsplus_setattr(struct mnt_idmap *idmap,
}
truncate_setsize(inode, attr->ia_size);
hfsplus_file_truncate(inode);
- inode->i_mtime = inode->i_ctime = current_time(inode);
+ inode->i_mtime = inode_ctime_set_current(inode);
}
setattr_copy(&nop_mnt_idmap, inode, attr);
@@ -392,7 +392,7 @@ struct inode *hfsplus_new_inode(struct super_block *sb, struct inode *dir,
inode->i_ino = sbi->next_cnid++;
inode_init_owner(&nop_mnt_idmap, inode, dir, mode);
set_nlink(inode, 1);
- inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode);
+ inode->i_mtime = inode->i_atime = inode_ctime_set_current(inode);
hip = HFSPLUS_I(inode);
INIT_LIST_HEAD(&hip->open_dir_list);
@@ -523,7 +523,7 @@ int hfsplus_cat_read_inode(struct inode *inode, struct hfs_find_data *fd)
inode->i_size = 2 + be32_to_cpu(folder->valence);
inode->i_atime = hfsp_mt2ut(folder->access_date);
inode->i_mtime = hfsp_mt2ut(folder->content_mod_date);
- inode->i_ctime = hfsp_mt2ut(folder->attribute_mod_date);
+ inode_ctime_set(inode, hfsp_mt2ut(folder->attribute_mod_date));
HFSPLUS_I(inode)->create_date = folder->create_date;
HFSPLUS_I(inode)->fs_blocks = 0;
if (folder->flags & cpu_to_be16(HFSPLUS_HAS_FOLDER_COUNT)) {
@@ -564,7 +564,7 @@ int hfsplus_cat_read_inode(struct inode *inode, struct hfs_find_data *fd)
}
inode->i_atime = hfsp_mt2ut(file->access_date);
inode->i_mtime = hfsp_mt2ut(file->content_mod_date);
- inode->i_ctime = hfsp_mt2ut(file->attribute_mod_date);
+ inode_ctime_set(inode, hfsp_mt2ut(file->attribute_mod_date));
HFSPLUS_I(inode)->create_date = file->create_date;
} else {
pr_err("bad catalog entry used to create inode\n");
@@ -609,7 +609,7 @@ int hfsplus_cat_write_inode(struct inode *inode)
hfsplus_cat_set_perms(inode, &folder->permissions);
folder->access_date = hfsp_ut2mt(inode->i_atime);
folder->content_mod_date = hfsp_ut2mt(inode->i_mtime);
- folder->attribute_mod_date = hfsp_ut2mt(inode->i_ctime);
+ folder->attribute_mod_date = hfsp_ut2mt(inode_ctime_peek(inode));
folder->valence = cpu_to_be32(inode->i_size - 2);
if (folder->flags & cpu_to_be16(HFSPLUS_HAS_FOLDER_COUNT)) {
folder->subfolders =
@@ -644,7 +644,7 @@ int hfsplus_cat_write_inode(struct inode *inode)
file->flags &= cpu_to_be16(~HFSPLUS_FILE_LOCKED);
file->access_date = hfsp_ut2mt(inode->i_atime);
file->content_mod_date = hfsp_ut2mt(inode->i_mtime);
- file->attribute_mod_date = hfsp_ut2mt(inode->i_ctime);
+ file->attribute_mod_date = hfsp_ut2mt(inode_ctime_peek(inode));
hfs_bnode_write(fd.bnode, &entry, fd.entryoffset,
sizeof(struct hfsplus_cat_file));
}
@@ -700,7 +700,7 @@ int hfsplus_fileattr_set(struct mnt_idmap *idmap,
else
hip->userflags &= ~HFSPLUS_FLG_NODUMP;
- inode->i_ctime = current_time(inode);
+ inode_ctime_set_current(inode);
mark_inode_dirty(inode);
return 0;
--
2.41.0
next prev parent reply other threads:[~2023-06-21 14:52 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230621144507.55591-1-jlayton@kernel.org>
2023-06-21 14:45 ` [PATCH 02/79] spufs: switch to new ctime accessors Jeff Layton
2023-06-21 14:45 ` [PATCH 03/79] s390: " Jeff Layton
2023-06-21 16:34 ` Jan Kara
2023-06-22 17:35 ` Alexander Gordeev
2023-06-22 17:51 ` Jeff Layton
2023-06-22 18:22 ` Alexander Gordeev
2023-06-22 18:46 ` Jeff Layton
2023-06-21 14:45 ` [PATCH 04/79] binderfs: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:35 ` Jan Kara
2023-06-21 14:45 ` [PATCH 05/79] qib_fs: " Jeff Layton
2023-06-21 16:35 ` Jan Kara
2023-06-21 19:37 ` Dennis Dalessandro
2023-06-21 14:45 ` [PATCH 06/79] ibm: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:35 ` Jan Kara
2023-06-21 14:45 ` [PATCH 07/79] usb: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 16:36 ` Jan Kara
2023-06-21 14:45 ` [PATCH 08/79] 9p: " Jeff Layton
2023-06-21 16:37 ` Jan Kara
2023-06-21 14:45 ` [PATCH 09/79] adfs: " Jeff Layton
2023-06-21 16:38 ` Jan Kara
2023-06-21 14:45 ` [PATCH 10/79] affs: " Jeff Layton
2023-06-21 16:39 ` Jan Kara
2023-06-22 11:37 ` David Sterba
2023-06-21 14:45 ` [PATCH 11/79] afs: " Jeff Layton
2023-06-21 16:43 ` Jan Kara
2023-06-21 14:45 ` [PATCH 12/79] fs: " Jeff Layton
2023-06-21 16:42 ` Jan Kara
2023-06-21 14:45 ` [PATCH 13/79] autofs: " Jeff Layton
2023-06-21 16:43 ` Jan Kara
2023-06-27 1:48 ` Ian Kent
2023-06-21 14:45 ` [PATCH 14/79] befs: " Jeff Layton
2023-06-21 16:44 ` Jan Kara
2023-06-21 14:45 ` [PATCH 15/79] bfs: " Jeff Layton
2023-06-21 16:48 ` Jan Kara
2023-06-21 16:57 ` Jeff Layton
2023-06-22 12:30 ` Jan Kara
2023-06-22 12:51 ` Jeff Layton
2023-06-22 14:57 ` Jan Kara
2023-06-23 12:33 ` Christian Brauner
2023-07-03 10:12 ` Christian Brauner
2023-07-03 10:46 ` Jeff Layton
2023-07-03 10:57 ` Christian Brauner
2023-06-21 14:45 ` [PATCH 16/79] btrfs: " Jeff Layton
2023-06-22 11:42 ` David Sterba
2023-06-21 14:45 ` [PATCH 17/79] ceph: " Jeff Layton
2023-06-26 0:56 ` Xiubo Li
2023-06-21 14:45 ` [PATCH 18/79] coda: " Jeff Layton
2023-06-21 14:45 ` [PATCH 19/79] configfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 20/79] cramfs: " Jeff Layton
2023-06-21 15:29 ` Nicolas Pitre
2023-06-21 14:45 ` [PATCH 21/79] debugfs: " Jeff Layton
2023-06-21 15:29 ` Greg Kroah-Hartman
2023-06-21 14:45 ` [PATCH 22/79] devpts: " Jeff Layton
2023-06-21 14:45 ` [PATCH 23/79] ecryptfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 24/79] efivarfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 25/79] efs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 26/79] erofs: " Jeff Layton
2023-06-22 4:01 ` Gao Xiang
2023-06-21 14:45 ` [PATCH 27/79] exfat: " Jeff Layton
2023-06-21 14:45 ` [PATCH 28/79] ext2: " Jeff Layton
2023-06-21 14:45 ` [PATCH 29/79] ext4: " Jeff Layton
2023-06-21 14:45 ` [PATCH 30/79] f2fs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 31/79] fat: " Jeff Layton
2023-06-21 14:45 ` [PATCH 32/79] freevxfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 33/79] fuse: " Jeff Layton
2023-06-21 14:45 ` [PATCH 34/79] gfs2: " Jeff Layton
2023-06-21 14:45 ` [PATCH 35/79] hfs: " Jeff Layton
2023-06-21 14:45 ` Jeff Layton [this message]
2023-06-21 14:45 ` [PATCH 37/79] hostfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 38/79] hpfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 39/79] hugetlbfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 40/79] isofs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 41/79] jffs2: " Jeff Layton
2023-06-21 14:45 ` [PATCH 42/79] jfs: " Jeff Layton
2023-06-21 17:47 ` Dave Kleikamp
2023-06-21 14:45 ` [PATCH 43/79] kernfs: " Jeff Layton
2023-06-21 15:30 ` Greg Kroah-Hartman
2023-06-21 14:45 ` [PATCH 44/79] minix: " Jeff Layton
2023-06-21 14:45 ` [PATCH 45/79] nfs: " Jeff Layton
2023-06-21 14:45 ` [PATCH 46/79] nfsd: " Jeff Layton
2023-06-21 17:36 ` Chuck Lever
2023-06-21 14:46 ` [PATCH 47/79] nilfs2: " Jeff Layton
2023-06-26 15:26 ` Ryusuke Konishi
2023-06-21 14:46 ` [PATCH 48/79] ntfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 49/79] ntfs3: " Jeff Layton
2023-06-21 14:46 ` [PATCH 50/79] ocfs2: " Jeff Layton
2023-06-21 14:46 ` [PATCH 51/79] omfs: " Jeff Layton
2023-06-23 12:12 ` Bob Copeland
2023-06-21 14:46 ` [PATCH 52/79] openpromfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 53/79] orangefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 54/79] overlayfs: " Jeff Layton
2023-06-22 6:44 ` Amir Goldstein
2023-06-21 14:46 ` [PATCH 55/79] proc: " Jeff Layton
2023-06-30 22:13 ` Luis Chamberlain
2023-06-21 14:46 ` [PATCH 56/79] pstore: " Jeff Layton
2023-06-21 17:50 ` Kees Cook
2023-06-21 14:46 ` [PATCH 57/79] qnx4: " Jeff Layton
2023-06-23 14:26 ` Anders Larsen
2023-06-21 14:46 ` [PATCH 58/79] qnx6: " Jeff Layton
2023-06-21 14:46 ` [PATCH 59/79] ramfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 60/79] reiserfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 61/79] romfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 62/79] smb: " Jeff Layton
2023-06-21 17:45 ` Tom Talpey
2023-06-23 5:03 ` Sergey Senozhatsky
2023-06-21 14:46 ` [PATCH 63/79] squashfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 64/79] sysv: " Jeff Layton
2023-06-21 14:46 ` [PATCH 65/79] tracefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 66/79] ubifs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 67/79] udf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 68/79] ufs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 69/79] vboxsf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 70/79] xfs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 71/79] zonefs: " Jeff Layton
2023-06-22 0:48 ` Damien Le Moal
2023-06-21 14:46 ` [PATCH 72/79] mqueue: " Jeff Layton
2023-06-21 14:46 ` [PATCH 73/79] bpf: " Jeff Layton
2023-06-21 14:46 ` [PATCH 74/79] shmem: " Jeff Layton
2023-06-21 14:46 ` [PATCH 75/79] rpc_pipefs: " Jeff Layton
2023-06-21 14:46 ` [PATCH 76/79] apparmor: " Jeff Layton
2023-06-22 9:04 ` John Johansen
2023-06-21 14:46 ` [PATCH 77/79] security: " Jeff Layton
2023-06-23 14:15 ` Paul Moore
2023-06-21 14:46 ` [PATCH 78/79] selinux: " Jeff Layton
2023-06-23 14:17 ` Paul Moore
2023-06-21 16:34 ` [PATCH 02/79] spufs: " Jan Kara
2023-06-22 0:19 ` Jeremy Kerr
[not found] ` <20230621152141.5961cf5f@gandalf.local.home>
[not found] ` <2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org>
2023-06-23 12:41 ` [PATCH 00/79] fs: new accessors for inode->i_ctime Christian Brauner
2023-06-30 22:11 ` Luis Chamberlain
[not found] ` <20230621144507.55591-2-jlayton@kernel.org>
[not found] ` <99b3c749-23d9-6f09-fb75-6a84f3d1b066@kernel.org>
2023-06-22 10:14 ` [PATCH 01/79] fs: add ctime accessors infrastructure Jeff Layton
2023-06-30 22:12 ` Luis Chamberlain
2023-07-12 15:31 ` Randy Dunlap
2023-07-12 15:34 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621144735.55953-35-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox