From: Lee Jones <lee@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: twl6040: Use maple tree register cache
Date: Wed, 21 Jun 2023 16:08:38 +0100 [thread overview]
Message-ID: <20230621150838.GG10378@google.com> (raw)
In-Reply-To: <20230609-mfd-twl6040-maple-v1-1-3493d051cd6f@kernel.org>
On Sat, 10 Jun 2023, Mark Brown wrote:
> The twl6040 is only capable of performing single register read and write
> operations which means it gains no advantage from using a rbtree register
> cache, convert it to using the more modern maple tree register cache
> instead. This should be more efficient.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/mfd/twl6040.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This has been applied for a while.
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index e982119bbefa..523439a16b7c 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -608,7 +608,7 @@ static const struct regmap_config twl6040_regmap_config = {
> .volatile_reg = twl6040_volatile_reg,
> .writeable_reg = twl6040_writeable_reg,
>
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> .use_single_read = true,
> .use_single_write = true,
> };
>
> ---
> base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
> change-id: 20230609-mfd-twl6040-maple-0904598891f2
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-06-21 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 14:05 [PATCH] mfd: twl6040: Use maple tree register cache Mark Brown
2023-06-21 15:08 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621150838.GG10378@google.com \
--to=lee@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox