* [PATCH] mfd: twl6040: Use maple tree register cache
@ 2023-06-10 14:05 Mark Brown
2023-06-21 15:08 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2023-06-10 14:05 UTC (permalink / raw)
To: Tony Lindgren, Lee Jones; +Cc: linux-omap, linux-kernel, Mark Brown
The twl6040 is only capable of performing single register read and write
operations which means it gains no advantage from using a rbtree register
cache, convert it to using the more modern maple tree register cache
instead. This should be more efficient.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/mfd/twl6040.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
index e982119bbefa..523439a16b7c 100644
--- a/drivers/mfd/twl6040.c
+++ b/drivers/mfd/twl6040.c
@@ -608,7 +608,7 @@ static const struct regmap_config twl6040_regmap_config = {
.volatile_reg = twl6040_volatile_reg,
.writeable_reg = twl6040_writeable_reg,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.use_single_read = true,
.use_single_write = true,
};
---
base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
change-id: 20230609-mfd-twl6040-maple-0904598891f2
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: twl6040: Use maple tree register cache
2023-06-10 14:05 [PATCH] mfd: twl6040: Use maple tree register cache Mark Brown
@ 2023-06-21 15:08 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-06-21 15:08 UTC (permalink / raw)
To: Mark Brown; +Cc: Tony Lindgren, linux-omap, linux-kernel
On Sat, 10 Jun 2023, Mark Brown wrote:
> The twl6040 is only capable of performing single register read and write
> operations which means it gains no advantage from using a rbtree register
> cache, convert it to using the more modern maple tree register cache
> instead. This should be more efficient.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/mfd/twl6040.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This has been applied for a while.
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index e982119bbefa..523439a16b7c 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -608,7 +608,7 @@ static const struct regmap_config twl6040_regmap_config = {
> .volatile_reg = twl6040_volatile_reg,
> .writeable_reg = twl6040_writeable_reg,
>
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> .use_single_read = true,
> .use_single_write = true,
> };
>
> ---
> base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
> change-id: 20230609-mfd-twl6040-maple-0904598891f2
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-21 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-10 14:05 [PATCH] mfd: twl6040: Use maple tree register cache Mark Brown
2023-06-21 15:08 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox