From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
alexandre.belloni@bootlin.com
Cc: Ben Dooks <ben.dooks@codethink.co.uk>
Subject: [RFC 1/5] i3c: show error with node for invalid reg property
Date: Wed, 21 Jun 2023 17:20:01 +0100 [thread overview]
Message-ID: <20230621162005.473049-2-ben.dooks@codethink.co.uk> (raw)
In-Reply-To: <20230621162005.473049-1-ben.dooks@codethink.co.uk>
When adding i3c devices via fdt, it is useful to get an error if the
reg node is wrong (say, you thought it was an i2c device and only
needed one value here) and have the error show the OF node which was
the cause of the problem (in case of many devices in the system),
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/i3c/master.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 08aeb69a7800..559fc2781a81 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2094,8 +2094,10 @@ static int of_i3c_master_add_dev(struct i3c_master_controller *master,
return -EINVAL;
ret = of_property_read_u32_array(node, "reg", reg, ARRAY_SIZE(reg));
- if (ret)
+ if (ret) {
+ dev_err(&master->dev, "%pOF: invalid reg property", node);
return ret;
+ }
/*
* The manufacturer ID can't be 0. If reg[1] == 0 that means we're
--
2.40.1
next prev parent reply other threads:[~2023-06-21 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 16:20 [RFC 0/5] updates for i3c error printing Ben Dooks
2023-06-21 16:20 ` Ben Dooks [this message]
2023-06-21 16:20 ` [RFC 2/5] i3c: add error print to show device failing during populate bus Ben Dooks
2023-06-21 16:20 ` [RFC 3/5] i3c: show node when printing unsupported 10-bit i2c dev Ben Dooks
2023-06-21 16:20 ` [RFC 4/5] i3c: show error messages in of_i3c_master_add_i3c_boardinfo Ben Dooks
2023-06-21 16:20 ` [RFC 5/5] i3c: dw; add print if cannot get resources Ben Dooks
2023-07-04 21:37 ` Alexandre Belloni
2023-07-11 8:52 ` Ben Dooks
2023-07-04 8:24 ` [RFC 0/5] updates for i3c error printing Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621162005.473049-2-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox