[PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible

[PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible

[Raymond Hackley]

Richtek's rt5033-led has pin configurations similar to sgm3140.
Add it to the compatable list.

[PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Raymond Hackley]

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
camera flash LEDs.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
index 4d2ffe5fcfc7..37d2a93780ab 100644
--- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led
       - sgmicro,sgm3140
 
   enable-gpios:
-- 
2.30.2

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Lee Jones]

On Fri, 02 Jun 2023, Raymond Hackley wrote:

> Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> camera flash LEDs.
> 
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> index 4d2ffe5fcfc7..37d2a93780ab 100644
> --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> @@ -20,6 +20,7 @@ properties:
>    compatible:
>      enum:
>        - ocs,ocp8110
> +      - richtek,rt5033-led

Why is "-led" appended on to this one and not the others?

>        - sgmicro,sgm3140
>  
> 
>    enable-gpios:
> -- 
> 
> 2.30.2
> 


-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Lee Jones]

On Wed, 21 Jun 2023, Lee Jones wrote:

> On Fri, 02 Jun 2023, Raymond Hackley wrote:
> 
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> > 
> > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> > ---
> >  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> >    compatible:
> >      enum:
> >        - ocs,ocp8110
> > +      - richtek,rt5033-led
> 
> Why is "-led" appended on to this one and not the others?

It's unusual for me to have to dump through a bunch of hoops just to
read and then subsequently reply to mail.  Can you consider removing
whatever encryption you have enabled please?

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

Raymond,

On Wed, Jun 21, 2023 at 04:03:02PM +0100, Lee Jones wrote:
> On Wed, 21 Jun 2023, Lee Jones wrote:
> 
> > On Fri, 02 Jun 2023, Raymond Hackley wrote:
> > 
> > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > > camera flash LEDs.
> > > 
> > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > @@ -20,6 +20,7 @@ properties:
> > >    compatible:
> > >      enum:
> > >        - ocs,ocp8110
> > > +      - richtek,rt5033-led
> > 
> > Why is "-led" appended on to this one and not the others?
> 
> It's unusual for me to have to dump through a bunch of hoops just to
> read and then subsequently reply to mail.  Can you consider removing
> whatever encryption you have enabled please?

https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail

I was under the impression that there was no way to disable this
behaviour, but I saw mention somewhere that they managed to patch the
open source version of the protonmail bridge to function. I cannot find
this on lore, because the person's domain was not a proton one and I
completely forget their name as it was several months ago.
I'll reply here if I find it.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Lee Jones]

On Wed, 21 Jun 2023, Conor Dooley wrote:

> Raymond,
> 
> On Wed, Jun 21, 2023 at 04:03:02PM +0100, Lee Jones wrote:
> > On Wed, 21 Jun 2023, Lee Jones wrote:
> > 
> > > On Fri, 02 Jun 2023, Raymond Hackley wrote:
> > > 
> > > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > > > camera flash LEDs.
> > > > 
> > > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > > > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > > > @@ -20,6 +20,7 @@ properties:
> > > >    compatible:
> > > >      enum:
> > > >        - ocs,ocp8110
> > > > +      - richtek,rt5033-led
> > > 
> > > Why is "-led" appended on to this one and not the others?
> > 
> > It's unusual for me to have to dump through a bunch of hoops just to
> > read and then subsequently reply to mail.  Can you consider removing
> > whatever encryption you have enabled please?
> 
> https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail

Thanks for the link.  This is perfect!

At least I know it's not just me being unreasonable.

> I was under the impression that there was no way to disable this
> behaviour, but I saw mention somewhere that they managed to patch the
> open source version of the protonmail bridge to function. I cannot find
> this on lore, because the person's domain was not a proton one and I
> completely forget their name as it was several months ago.
> I'll reply here if I find it.

Thanks.

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

On Wed, Jun 21, 2023 at 06:05:24PM +0100, Lee Jones wrote:
> On Wed, 21 Jun 2023, Conor Dooley wrote:
> > On Wed, Jun 21, 2023 at 04:03:02PM +0100, Lee Jones wrote:
> > > On Wed, 21 Jun 2023, Lee Jones wrote:
> > > > On Fri, 02 Jun 2023, Raymond Hackley wrote:

> > > It's unusual for me to have to dump through a bunch of hoops just to
> > > read and then subsequently reply to mail.  Can you consider removing
> > > whatever encryption you have enabled please?
> > 
> > https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail
> 
> Thanks for the link.  This is perfect!

Ye, no worries chief. I got yelled at about it when I started out, so
figured I should at least document it after I noticed others getting
yelled at for the same reason, since it is a bit insidious.

> At least I know it's not just me being unreasonable.
> 
> > I was under the impression that there was no way to disable this
> > behaviour, but I saw mention somewhere that they managed to patch the
> > open source version of the protonmail bridge to function. I cannot find
> > this on lore, because the person's domain was not a proton one and I
> > completely forget their name as it was several months ago.
> > I'll reply here if I find it.

It was Marc Bornand. Add to CC.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Raymond Hackley]

Hi Lee,

On Wednesday, June 21st, 2023 at 3:01 PM, Lee Jones <lee@kernel.org> wrote:


> On Fri, 02 Jun 2023, Raymond Hackley wrote:
> 
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> > 
> > Signed-off-by: Raymond Hackley raymondhackley@protonmail.com
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> > compatible:
> > enum:
> > - ocs,ocp8110
> > + - richtek,rt5033-led
> 
> 
> Why is "-led" appended on to this one and not the others?
> 

"richtek,rt5033" has already been taken by a MFD device, and this LED is
a part of rt5033 MFD, so "-led" is appended here.

> > - sgmicro,sgm3140
> > 
> > enable-gpios:
> > --
> > 
> > 2.30.2

I tried to configure protonmail not to send encrypted mails.
Hope that it works for you.

Regards,
Raymond

Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Raymond Hackley]

Hi Krzysztof,

On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 02/06/2023 15:38, Raymond Hackley wrote:
> 
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> 
> 
> What are the similarities? Same register interface? Same pins? It's not
> obvious and your commit should clear explain this. It will be also
> justification why you did not make devices compatible.
> 

There is a similar way to control with 2 GPIO pins, strobe and enable,
which is not described well in this patch set.

Regards,
Raymond

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

[Lee Jones]

On Fri, 02 Jun 2023, Raymond Hackley wrote:

> Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> camera flash LEDs.
> 
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

-- 
Lee Jones [李琼斯]

[PATCH 2/2] leds: sgm3140: Add richtek,rt5033-led compatible

[Raymond Hackley]

Richtek's rt5033-led has pin configurations similar to sgm3140.
Add it to the compatible list.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 drivers/leds/flash/leds-sgm3140.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sgm3140.c
index d3a30ad94ac4..d3f50dca5136 100644
--- a/drivers/leds/flash/leds-sgm3140.c
+++ b/drivers/leds/flash/leds-sgm3140.c
@@ -291,6 +291,7 @@ static int sgm3140_remove(struct platform_device *pdev)
 
 static const struct of_device_id sgm3140_dt_match[] = {
 	{ .compatible = "ocs,ocp8110" },
+	{ .compatible = "richtek,rt5033-led" },
 	{ .compatible = "sgmicro,sgm3140" },
 	{ /* sentinel */ }
 };
-- 
2.30.2

Re: [PATCH 2/2] leds: sgm3140: Add richtek,rt5033-led compatible

[Lee Jones]

On Fri, 02 Jun 2023, Raymond Hackley wrote:

> Richtek's rt5033-led has pin configurations similar to sgm3140.
> Add it to the compatible list.
> 
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
>  drivers/leds/flash/leds-sgm3140.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

-- 
Lee Jones [李琼斯]