From: Lee Jones <lee@kernel.org>
To: baomingtong001@208suo.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sm501: prefer unsigned int over unsigned
Date: Wed, 21 Jun 2023 18:18:29 +0100 [thread overview]
Message-ID: <20230621171829.GN10378@google.com> (raw)
In-Reply-To: <25f84d945d94832e8d6b295cff004439@208suo.com>
On Tue, 13 Jun 2023, baomingtong001@208suo.com wrote:
>
> Fix the following coccicheck warning:
>
> drivers/mfd/sm501.c:887: Prefer 'unsigned int' to bare use of 'unsigned'.
>
> Signed-off-by: Mindtong Bao <baomingtong001@208suo.com>
> ---
> drivers/mfd/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch did not make it to the upstream mailing list (LKML).
https://lore.kernel.org/all/?q=%22mfd%3A+sm501%3A+prefer+unsigned+int+over+unsigned%22
I cannot take it unless it shows up there first.
Please debug this and resend.
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index 28027982cf69..f08ad7249dc5 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -884,7 +884,7 @@ static inline struct sm501_devdata
> *sm501_gpio_to_dev(struct sm501_gpio *gpio)
> return container_of(gpio, struct sm501_devdata, gpio);
> }
>
> -static int sm501_gpio_get(struct gpio_chip *chip, unsigned offset)
> +static int sm501_gpio_get(struct gpio_chip *chip, unsigned int offset)
>
> {
> struct sm501_gpio_chip *smgpio = gpiochip_get_data(chip);
--
Lee Jones [李琼斯]
parent reply other threads:[~2023-06-21 17:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <25f84d945d94832e8d6b295cff004439@208suo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621171829.GN10378@google.com \
--to=lee@kernel.org \
--cc=baomingtong001@208suo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox