* [PATCH] dt-bindings: mfd: samsung,s5m8767: Simplify excluding properties
@ 2023-06-19 10:14 Krzysztof Kozlowski
2023-06-19 21:16 ` Conor Dooley
2023-06-21 17:56 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-19 10:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Lee Jones, Rob Herring, Conor Dooley,
linux-kernel, linux-samsung-soc, devicetree
Mutually exclusive s5m8767,pmic-buck[234]-uses-gpio-dvs properties can
be written simpler, with half of the lines of code.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/mfd/samsung,s5m8767.yaml | 25 ++++++-------------
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
index 10c7b408f33a..aea0b7d57d04 100644
--- a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
+++ b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
@@ -153,29 +153,18 @@ dependencies:
additionalProperties: false
allOf:
- - if:
+ - not:
required:
- s5m8767,pmic-buck2-uses-gpio-dvs
- then:
- properties:
- s5m8767,pmic-buck3-uses-gpio-dvs: false
- s5m8767,pmic-buck4-uses-gpio-dvs: false
-
- - if:
+ - s5m8767,pmic-buck3-uses-gpio-dvs
+ - not:
+ required:
+ - s5m8767,pmic-buck2-uses-gpio-dvs
+ - s5m8767,pmic-buck4-uses-gpio-dvs
+ - not:
required:
- s5m8767,pmic-buck3-uses-gpio-dvs
- then:
- properties:
- s5m8767,pmic-buck2-uses-gpio-dvs: false
- s5m8767,pmic-buck4-uses-gpio-dvs: false
-
- - if:
- required:
- s5m8767,pmic-buck4-uses-gpio-dvs
- then:
- properties:
- s5m8767,pmic-buck2-uses-gpio-dvs: false
- s5m8767,pmic-buck3-uses-gpio-dvs: false
examples:
- |
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: mfd: samsung,s5m8767: Simplify excluding properties
2023-06-19 10:14 [PATCH] dt-bindings: mfd: samsung,s5m8767: Simplify excluding properties Krzysztof Kozlowski
@ 2023-06-19 21:16 ` Conor Dooley
2023-06-21 17:56 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-06-19 21:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Conor Dooley, linux-kernel,
linux-samsung-soc, devicetree
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
On Mon, Jun 19, 2023 at 12:14:24PM +0200, Krzysztof Kozlowski wrote:
> Mutually exclusive s5m8767,pmic-buck[234]-uses-gpio-dvs properties can
> be written simpler, with half of the lines of code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mfd: samsung,s5m8767: Simplify excluding properties
2023-06-19 10:14 [PATCH] dt-bindings: mfd: samsung,s5m8767: Simplify excluding properties Krzysztof Kozlowski
2023-06-19 21:16 ` Conor Dooley
@ 2023-06-21 17:56 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-06-21 17:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Conor Dooley, linux-kernel, linux-samsung-soc,
devicetree
On Mon, 19 Jun 2023, Krzysztof Kozlowski wrote:
> Mutually exclusive s5m8767,pmic-buck[234]-uses-gpio-dvs properties can
> be written simpler, with half of the lines of code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/mfd/samsung,s5m8767.yaml | 25 ++++++-------------
> 1 file changed, 7 insertions(+), 18 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-21 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 10:14 [PATCH] dt-bindings: mfd: samsung,s5m8767: Simplify excluding properties Krzysztof Kozlowski
2023-06-19 21:16 ` Conor Dooley
2023-06-21 17:56 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox