Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Raymond Hackley
2023-06-21T17:48:02Z

Hi Lee,

On Wednesday, June 21st, 2023 at 3:01 PM, Lee Jones <lee@kernel.org> wrote:

> On Fri, 02 Jun 2023, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> >
> > Signed-off-by: Raymond Hackley raymondhackley@protonmail.com
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> > compatible:
> > enum:
> > - ocs,ocp8110
> > + - richtek,rt5033-led
>
>
> Why is "-led" appended on to this one and not the others?
>

"richtek,rt5033" has already been taken by a MFD device, and this LED is
a part of rt5033 MFD, so "-led" is appended here.

> > - sgmicro,sgm3140
> >
> > enable-gpios:
> > --
> >
> > 2.30.2

I tried to configure protonmail not to send encrypted mails.
Hope that it works for you.

Regards,
Raymond