From: Greg KH <greg@kroah.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v1 1/1] usb: ulpi: Make container_of() no-op in to_ulpi_dev()
Date: Wed, 21 Jun 2023 21:08:06 +0200 [thread overview]
Message-ID: <2023062144-impose-wrecking-2315@gregkh> (raw)
In-Reply-To: <20230621163122.5693-1-andriy.shevchenko@linux.intel.com>
On Wed, Jun 21, 2023 at 07:31:22PM +0300, Andy Shevchenko wrote:
> Move embedded struct device member to make container_of() noop
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/ulpi/driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ulpi/driver.h b/include/linux/ulpi/driver.h
> index c7a1810373e3..a8cb617a3028 100644
> --- a/include/linux/ulpi/driver.h
> +++ b/include/linux/ulpi/driver.h
> @@ -15,9 +15,9 @@ struct ulpi_ops;
> * @dev: device interface
> */
> struct ulpi {
> + struct device dev;
> struct ulpi_device_id id;
> const struct ulpi_ops *ops;
> - struct device dev;
CPUs don't like doing pointer math anymore? :)
I'll go queue this up, thanks for the micro-optimization.
greg k-h
prev parent reply other threads:[~2023-06-21 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 16:31 [PATCH v1 1/1] usb: ulpi: Make container_of() no-op in to_ulpi_dev() Andy Shevchenko
2023-06-21 19:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023062144-impose-wrecking-2315@gregkh \
--to=greg@kroah.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox