From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Breno Leitao <leitao@debian.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
leit@fb.com,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: Print capabilities changes just once
Date: Thu, 22 Jun 2023 05:57:53 +0200 [thread overview]
Message-ID: <20230622035753.GA4736@lst.de> (raw)
In-Reply-To: <ZJMpWaMxKMFE8hmK@kbusch-mbp.dhcp.thefacebook.com>
On Wed, Jun 21, 2023 at 10:46:17AM -0600, Keith Busch wrote:
> On Thu, Jun 15, 2023 at 02:49:03AM -0700, Breno Leitao wrote:
> > if (effects & NVME_CMD_EFFECTS_CCC) {
> > - dev_info(ctrl->device,
> > + if (!test_and_set_bit(NVME_CTRL_DIRTY_CAPABILITY,
> > + &ctrl->flags)) {
> > + dev_info(ctrl->device,
> > "controller capabilities changed, reset may be required to take effect.\n");
> > + }
> > }
>
> Thanks, patch applied to nvme-6.5.
>
> A question for Christoph and future consideration: I *think* the
> complications that had the driver stop refreshing the controller
> attributes are largely mitigated by the fact we now handle effects
> after the request is freed. Perhaps I'm missing something. Is there
> a risk in just bringing that feature back into the driver?
No, the main issue was and is that we can't just call
nvme_init_ctrl_finish on a live controller.
prev parent reply other threads:[~2023-06-22 4:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 9:49 [PATCH v2] nvme: Print capabilities changes just once Breno Leitao
2023-06-15 18:30 ` Keith Busch
2023-06-20 1:41 ` Chaitanya Kulkarni
2023-06-20 14:13 ` Sagi Grimberg
2023-06-21 16:46 ` Keith Busch
2023-06-22 3:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622035753.GA4736@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=leit@fb.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox