* [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active()
@ 2023-06-22 7:51 Johan Hovold
2023-07-11 16:44 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2023-06-22 7:51 UTC (permalink / raw)
To: Sean Wang, Vinod Koul
Cc: Matthias Brugger, AngeloGioacchino Del Regno, dmaengine,
linux-arm-kernel, linux-mediatek, linux-kernel, Johan Hovold
The runtime PM state must be updated while runtime PM is disabled for
the change to take effect.
Drop the bogus pm_runtime_set_active() which left the PM state set to
suspended (as it should be or the clock would not be enabled when the
device is resumed).
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/dma/mediatek/mtk-uart-apdma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
index a1517ef1f4a0..92864c9371a3 100644
--- a/drivers/dma/mediatek/mtk-uart-apdma.c
+++ b/drivers/dma/mediatek/mtk-uart-apdma.c
@@ -551,7 +551,6 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev)
}
pm_runtime_enable(&pdev->dev);
- pm_runtime_set_active(&pdev->dev);
rc = dma_async_device_register(&mtkd->ddev);
if (rc)
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active()
2023-06-22 7:51 [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active() Johan Hovold
@ 2023-07-11 16:44 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-07-11 16:44 UTC (permalink / raw)
To: Sean Wang, Johan Hovold
Cc: Matthias Brugger, AngeloGioacchino Del Regno, dmaengine,
linux-arm-kernel, linux-mediatek, linux-kernel
On Thu, 22 Jun 2023 09:51:50 +0200, Johan Hovold wrote:
> The runtime PM state must be updated while runtime PM is disabled for
> the change to take effect.
>
> Drop the bogus pm_runtime_set_active() which left the PM state set to
> suspended (as it should be or the clock would not be enabled when the
> device is resumed).
>
> [...]
Applied, thanks!
[1/1] dmaengine: mediatek: drop bogus pm_runtime_set_active()
commit: 1775a0d9f021739a69e4cf12c049801c9cf1a072
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-11 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-22 7:51 [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active() Johan Hovold
2023-07-11 16:44 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox