From: Kees Cook <keescook@chromium.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, alyssa.milburn@linux.intel.com,
linux-kernel@vger.kernel.org, samitolvanen@google.com,
jpoimboe@kernel.org, joao@overdrivepizza.com, brgerst@gmail.com
Subject: Re: [PATCH v2 0/6] x86/cfi: Fix FineIBT
Date: Thu, 22 Jun 2023 09:14:17 -0700 [thread overview]
Message-ID: <202306220913.2482F76F@keescook> (raw)
In-Reply-To: <20230622144218.860926475@infradead.org>
On Thu, Jun 22, 2023 at 04:42:18PM +0200, Peter Zijlstra wrote:
> Alyssa reported a FineIBT issue (patch 6) which led to the discovery of
> a kCFI issue (patch 5) and a bunch of cleanups and enhancements (the
> rest).
>
> Backports can probably suffice with just the last two.
>
> Much thanks to Brian for the better ret_from_fork() cleanup.
>
> Tested using llvm-16 on an Alderlake with both FineIBT and kCFI.
Thanks! This looks really nice. For the series:
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-06-22 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 14:42 [PATCH v2 0/6] x86/cfi: Fix FineIBT Peter Zijlstra
2023-06-22 14:42 ` [PATCH v2 1/6] x86/cfi: Extend {JMP,CAKK}_NOSPEC comment Peter Zijlstra
2023-06-22 14:42 ` [PATCH v2 2/6] x86/alternative: Rename apply_ibt_endbr() Peter Zijlstra
2023-06-22 14:42 ` [PATCH v2 3/6] x86/cfi: Extend ENDBR sealing to kCFI Peter Zijlstra
2023-06-22 14:42 ` [PATCH v2 4/6] x86/32: Remove schedule_tail_wrapper() Peter Zijlstra
2023-06-22 14:42 ` [PATCH v2 5/6] x86: Rewrite ret_from_fork() in C Peter Zijlstra
2023-06-22 14:42 ` [PATCH v2 6/6] x86/fineibt: Poison ENDBR at +0 Peter Zijlstra
2023-06-22 16:14 ` Kees Cook [this message]
2023-06-23 0:20 ` [PATCH v2 0/6] x86/cfi: Fix FineIBT Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306220913.2482F76F@keescook \
--to=keescook@chromium.org \
--cc=alyssa.milburn@linux.intel.com \
--cc=brgerst@gmail.com \
--cc=joao@overdrivepizza.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox