From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAAD9EB64D8 for ; Thu, 22 Jun 2023 09:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231484AbjFVJ4i (ORCPT ); Thu, 22 Jun 2023 05:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbjFVJ4P (ORCPT ); Thu, 22 Jun 2023 05:56:15 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B3E1BE3; Thu, 22 Jun 2023 02:53:29 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Qmwdc5CyZz6J72y; Thu, 22 Jun 2023 17:52:20 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 22 Jun 2023 10:53:27 +0100 Date: Thu, 22 Jun 2023 10:53:26 +0100 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , Subject: Re: [PATCH v6 03/27] cxl: Updates for CXL Test to work with RCH Message-ID: <20230622105326.00006302@Huawei.com> In-Reply-To: <20230622035126.4130151-4-terry.bowman@amd.com> References: <20230622035126.4130151-1-terry.bowman@amd.com> <20230622035126.4130151-4-terry.bowman@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jun 2023 22:51:02 -0500 Terry Bowman wrote: > From: Dan Williams > > CXL test needs to be updated to work with latest RCH changes. > Add CXL test support for devm_cxl_add_rch_dport and > cxl_rcd_component_reg_phys functions. > > Signed-off-by: Dan Williams > Signed-off-by: Terry Bowman > Signed-off-by: Robert Richter This chain is getting confusing. Why a SoB from Robert on this one? As Terry sent the series I'd expect Terry to be last unless there was some codevelopment involved in which case that should be indicated in the tags. For weird corner cases it's worth adding some comments on why a SoB chain is non obvious. I'm far from an expert on cxl-test so I'll leave reviewing this in depth to others. FWIW looks fine to me. Jonathan