public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Juergen Gross <jgross@suse.com>
Cc: Per Bilse <Per.Bilse@citrix.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	"open list:X86 ENTRY CODE" <linux-kernel@vger.kernel.org>,
	"moderated list:XEN HYPERVISOR INTERFACE" 
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] Updates to Xen hypercall preemption
Date: Thu, 22 Jun 2023 13:15:52 +0200	[thread overview]
Message-ID: <20230622111552.GI4253@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <4d29bfe0-975a-c97f-3e79-5b77d95d3494@suse.com>

On Thu, Jun 22, 2023 at 12:33:31PM +0200, Juergen Gross wrote:
> On 22.06.23 10:26, Peter Zijlstra wrote:

> > > The downside would be that some workloads might see worse performance
> > > due to backend I/O handling might get preempted.
> > 
> > Is that an actual concern? Mark this a legaxy inteface and anybody who
> > wants to get away from it updates.
> 
> It isn't that easy. See above.

Well, the old stuff gets to use full preemption on Dom0, then the new
stuff gets more shiny options.

> > > Just thinking - can full preemption be enabled per process?
> > 
> > Nope, that's a system wide thing. Preemption is something that's driven
> > by the requirements of the tasks that preempt, not something by the
> > tasks that get preempted.
> 
> Depends. If a task in a non-preempt system could switch itself to be
> preemptable, we could do so around hypercalls without compromising the
> general preemption setting. Disabling preemption in a preemptable system
> should continue to be possible for short code paths only, of course.

So something along those lines was suggested elsewhere, and I'm still
not entirely sure how I feel about it, but look here:

  https://lkml.kernel.org/r/20230403052233.1880567-1-ankur.a.arora@oracle.com

Specifically patches 7 and 8. It is very close so that you currently
do/want. Those patches are many moons old and i've not seen an update on
them, so I've no idea where they are.

It solves a similar problem except it is 'rep string' instructions
that's being interrupted.

  reply	other threads:[~2023-06-22 11:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 15:14 [PATCH] Updates to Xen hypercall preemption Per Bilse
2023-06-21 16:27 ` Andy Lutomirski
2023-06-21 19:05   ` Per Bilse
2023-06-21 23:42     ` Andy Lutomirski
2023-06-21 16:40 ` Peter Zijlstra
2023-06-21 19:19   ` Per Bilse
2023-06-21 20:04     ` Peter Zijlstra
2023-06-22  5:22       ` Juergen Gross
2023-06-22  8:26         ` Peter Zijlstra
2023-06-22 10:33           ` Juergen Gross
2023-06-22 11:15             ` Peter Zijlstra [this message]
2023-06-22 12:17               ` Juergen Gross
2023-06-22 16:39             ` Andy Lutomirski
2023-06-22 17:20               ` Juergen Gross
2023-06-24 15:19                 ` Andy Lutomirski
2023-06-22 13:05           ` Andrew Cooper
2023-06-22 13:14             ` Peter Zijlstra
2023-06-22 13:35             ` Juergen Gross
2023-06-22 10:01       ` Per Bilse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230622111552.GI4253@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Per.Bilse@citrix.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox