From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62D0EB64DA for ; Thu, 22 Jun 2023 20:32:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231162AbjFVUcO (ORCPT ); Thu, 22 Jun 2023 16:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbjFVUcM (ORCPT ); Thu, 22 Jun 2023 16:32:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24DFF1FF0 for ; Thu, 22 Jun 2023 13:32:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3A8D617AA for ; Thu, 22 Jun 2023 20:32:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B66DEC433C8; Thu, 22 Jun 2023 20:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687465926; bh=UIN7vbEVF4QwHSBcKRVm9rZeEKOWGNBryfxnm2JqxHc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VfzrcJNDTADNxZLzWKciLQRYu+9nq1/G4islfOdNF43uWQdxT0kHF3tQn9mCixHWV xZTEn3AWgWdN4D/DB+CFPlVlwmLV3DRAVex3AkpjMh5zJoxWP6nHE0SW80Qe0Kgza+ ZJP8xwy2+AR/jv9XxjkMYN+jy48KK83wZAW4YLbTPfk5Cl9PpWhFov9dzd6wQ8DHMb i2liKBmsuV0ZGkdNCWEP08f9OnIYIhkDiAsHtFtPqU+mSE3gOFsZ1HhsBVF/y6jdce NeKzNaf3EJQfx8sThzuALfLD5h04GAVz4kw8ZOmCPRR+sGgFdSWInuoElCE5RKW8uj NSfvuvNQVY51g== Date: Thu, 22 Jun 2023 13:32:04 -0700 From: Jakub Kicinski To: Maxim Kochetkov Cc: netdev@vger.kernel.org, Robert Hancock , Radhey Shyam Pandey , "David S. Miller" , Eric Dumazet , Paolo Abeni , Michal Simek , Andre Przywara , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/1] net: axienet: Move reset before 64-bit DMA detection Message-ID: <20230622133204.2ba95c21@kernel.org> In-Reply-To: <20230622192245.116864-1-fido_max@inbox.ru> References: <20230622192245.116864-1-fido_max@inbox.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Jun 2023 22:22:45 +0300 Maxim Kochetkov wrote: > 64-bit DMA detection will fail if axienet was started before (by boot > loader, boot ROM, etc). In this state axienet will not start properly. > XAXIDMA_TX_CDESC_OFFSET + 4 register (MM2S_CURDESC_MSB) is used to detect > 64-bit DMA capability here. But datasheet says: When DMACR.RS is 1 > (axienet is in enabled state), CURDESC_PTR becomes Read Only (RO) and > is used to fetch the first descriptor. So iowrite32()/ioread32() trick > to this register to detect 64-bit DMA will not work. > So move axienet reset before 64-bit DMA detection. > > Fixes: f735c40ed93c ("net: axienet: Autodetect 64-bit DMA capability") > Signed-off-by: Maxim Kochetkov > Reviewed-by: Robert Hancock > Reviewed-by: Radhey Shyam Pandey Quoting documentation: Resending after review ~~~~~~~~~~~~~~~~~~~~~~ Allow at least 24 hours to pass between postings. This will ensure reviewers from all geographical locations have a chance to chime in. Do not wait too long (weeks) between postings either as it will make it harder for reviewers to recall all the context. Make sure you address all the feedback in your new posting. Do not post a new version of the code if the discussion about the previous version is still ongoing, unless directly instructed by a reviewer. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review