From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8531EB64D8 for ; Thu, 22 Jun 2023 14:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbjFVOBY (ORCPT ); Thu, 22 Jun 2023 10:01:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230469AbjFVOBP (ORCPT ); Thu, 22 Jun 2023 10:01:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAF27E2 for ; Thu, 22 Jun 2023 07:01:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E1686185A for ; Thu, 22 Jun 2023 14:01:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02BF1C433C0; Thu, 22 Jun 2023 14:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687442462; bh=z7/NrKf78pVSzF93LgcyirSWoE1Vw6K1NkBXiHs5xRI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FJC+7VJggnkd3EEuT1MK/6WJwYkZgMsImkwXts+v+Fhn5a8CMPGLfzuMPw3DOtyiM gwy5303hHEZJdq3j/GbVehgeLtuBfhYOX2wdPwRciNkkUL+L/hzQB4CWNM4tlAejts sLz042m0txbVQpvnTYt0NJSRS2E5P5T4MBt2vu0I+QKFOLO9ZRFH1o96WAMQE22eHk GtdOU1/MDGMUMorZ2II7lhFfDDrijX7lPqNCsUYoM1gz6AnuRMCc3qTu+odYOm/+5e iKxnVgzAVmhEXuaZ1l1BDrA0ZO/43227vo9VmHe0snLH8H/b1LPaUAqJVCp475du4i ihfHjyP+XBp9g== Date: Thu, 22 Jun 2023 15:00:58 +0100 From: Lee Jones To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] mfd: ipaq-micro: Use %*ph for printing hexdump of a small buffer Message-ID: <20230622140058.GW10378@google.com> References: <20230612212007.3621-1-andriy.shevchenko@linux.intel.com> <20230621171040.GK10378@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Jun 2023, Andy Shevchenko wrote: > On Wed, Jun 21, 2023 at 06:10:40PM +0100, Lee Jones wrote: > > On Tue, 13 Jun 2023, Andy Shevchenko wrote: > > > > > The kernel already has a helper to print a hexdump of a small > > > buffer via pointer extension. Use that instead of open coded > > > variant. > > > > That's not all you're doing is it? > > > > Nice try. 2 patches please. > > I'm not sure it's possible to split to two clean patches that don't overlap > each other like by 70%. Can you elaborate a bit more on your vision on this? What does the 'break' have to do with changing print format? -- Lee Jones [李琼斯]