From: Wilken Gottwalt <wilken.gottwalt@posteo.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: corsair-psu: add support for reading PWM values and mode
Date: Thu, 22 Jun 2023 17:06:45 +0000 [thread overview]
Message-ID: <20230622190645.403dd36b@posteo.net> (raw)
In-Reply-To: <75153707-e115-d6f8-0f47-ac678aebedd4@roeck-us.net>
On Thu, 22 Jun 2023 07:00:28 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> On 6/22/23 00:47, Wilken Gottwalt wrote:
> > Also updates the documentation and comments accordingly. Fixes several
> > typos and updates the coding style to be more uniform.
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
>
> I don't mind minor cleanups combined with functional changes, but this is
> too much. Please split into two patches.
Oh, this is fine. I already spotted another typo in the newly added PWMs in
the documentation.
greetings,
Will
prev parent reply other threads:[~2023-06-22 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 7:47 [PATCH] hwmon: corsair-psu: add support for reading PWM values and mode Wilken Gottwalt
2023-06-22 14:00 ` Guenter Roeck
2023-06-22 17:06 ` Wilken Gottwalt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622190645.403dd36b@posteo.net \
--to=wilken.gottwalt@posteo.net \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox