From: Greg KH <gregkh@linuxfoundation.org>
To: David Howells <dhowells@redhat.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
linux-cachefs@redhat.com, linux-kernel@vger.kernel.org,
arnd@arndb.de
Subject: Re: [PATCH] cachefiles: allocate static minor for /dev/cachefiles
Date: Thu, 22 Jun 2023 16:51:18 +0200 [thread overview]
Message-ID: <2023062245-synopses-scared-9d96@gregkh> (raw)
In-Reply-To: <1886146.1687441374@warthog.procyon.org.uk>
On Thu, Jun 22, 2023 at 02:42:54PM +0100, David Howells wrote:
> Marcel Holtmann <marcel@holtmann.org> wrote:
>
> > The cachefiles misc character device uses MISC_DYNAMIC_MINOR and thus
> > doesn't support module auto-loading. Assign a static minor number for it
> > and provide appropriate module aliases for it. This is enough for kmod to
> > create the /dev/cachefiles device node on startup and facility module
> > auto-loading.
>
> Why? The systemd unit file for it just modprobe's the module first. It's a
> specialist device file only for use by the appropriate daemon.
And you really don't want to have auto-module-loading when trying to
open a /dev/foo file, that way lies madness in the past, please let's
learn from our mistakes :)
thanks,
greg k-h
next prev parent reply other threads:[~2023-06-22 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 16:08 [PATCH] cachefiles: allocate static minor for /dev/cachefiles Marcel Holtmann
2023-06-22 13:42 ` David Howells
2023-06-22 14:51 ` Greg KH [this message]
2023-06-25 8:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023062245-synopses-scared-9d96@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox