* [PATCH][next] smb: Replace one-element array with flexible-array member
@ 2023-06-21 21:12 Gustavo A. R. Silva
2023-06-21 21:27 ` Kees Cook
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2023-06-21 21:12 UTC (permalink / raw)
To: Namjae Jeon, Steve French, Sergey Senozhatsky, Tom Talpey
Cc: linux-cifs, linux-kernel, Gustavo A. R. Silva, linux-hardening
One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element array with flexible-array
member in struct smb_negotiate_req.
This results in no differences in binary output.
Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/317
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
fs/smb/server/smb_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/smb/server/smb_common.h b/fs/smb/server/smb_common.h
index 6b0d5f1fe85c..aeca0f46068f 100644
--- a/fs/smb/server/smb_common.h
+++ b/fs/smb/server/smb_common.h
@@ -200,7 +200,7 @@ struct smb_hdr {
struct smb_negotiate_req {
struct smb_hdr hdr; /* wct = 0 */
__le16 ByteCount;
- unsigned char DialectsArray[1];
+ unsigned char DialectsArray[];
} __packed;
struct smb_negotiate_rsp {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] smb: Replace one-element array with flexible-array member
2023-06-21 21:12 [PATCH][next] smb: Replace one-element array with flexible-array member Gustavo A. R. Silva
@ 2023-06-21 21:27 ` Kees Cook
2023-06-21 23:37 ` Namjae Jeon
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Kees Cook @ 2023-06-21 21:27 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Namjae Jeon, Steve French, Sergey Senozhatsky, Tom Talpey,
linux-cifs, linux-kernel, linux-hardening
On Wed, Jun 21, 2023 at 03:12:42PM -0600, Gustavo A. R. Silva wrote:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct smb_negotiate_req.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/317
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] smb: Replace one-element array with flexible-array member
2023-06-21 21:12 [PATCH][next] smb: Replace one-element array with flexible-array member Gustavo A. R. Silva
2023-06-21 21:27 ` Kees Cook
@ 2023-06-21 23:37 ` Namjae Jeon
2023-06-23 5:00 ` Sergey Senozhatsky
2023-06-24 3:49 ` Namjae Jeon
3 siblings, 0 replies; 5+ messages in thread
From: Namjae Jeon @ 2023-06-21 23:37 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Steve French, Sergey Senozhatsky, Tom Talpey, linux-cifs,
linux-kernel, linux-hardening
2023-06-22 6:12 GMT+09:00, Gustavo A. R. Silva <gustavoars@kernel.org>:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct smb_negotiate_req.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/317
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] smb: Replace one-element array with flexible-array member
2023-06-21 21:12 [PATCH][next] smb: Replace one-element array with flexible-array member Gustavo A. R. Silva
2023-06-21 21:27 ` Kees Cook
2023-06-21 23:37 ` Namjae Jeon
@ 2023-06-23 5:00 ` Sergey Senozhatsky
2023-06-24 3:49 ` Namjae Jeon
3 siblings, 0 replies; 5+ messages in thread
From: Sergey Senozhatsky @ 2023-06-23 5:00 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Namjae Jeon, Steve French, Sergey Senozhatsky, Tom Talpey,
linux-cifs, linux-kernel, linux-hardening
On (23/06/21 15:12), Gustavo A. R. Silva wrote:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct smb_negotiate_req.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/317
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] smb: Replace one-element array with flexible-array member
2023-06-21 21:12 [PATCH][next] smb: Replace one-element array with flexible-array member Gustavo A. R. Silva
` (2 preceding siblings ...)
2023-06-23 5:00 ` Sergey Senozhatsky
@ 2023-06-24 3:49 ` Namjae Jeon
3 siblings, 0 replies; 5+ messages in thread
From: Namjae Jeon @ 2023-06-24 3:49 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Steve French, Sergey Senozhatsky, Tom Talpey, linux-cifs,
linux-kernel, linux-hardening
2023-06-22 6:12 GMT+09:00, Gustavo A. R. Silva <gustavoars@kernel.org>:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct smb_negotiate_req.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/317
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Applied it with reviewed/acked-by tags to #ksmbd-for-next-next.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-24 3:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 21:12 [PATCH][next] smb: Replace one-element array with flexible-array member Gustavo A. R. Silva
2023-06-21 21:27 ` Kees Cook
2023-06-21 23:37 ` Namjae Jeon
2023-06-23 5:00 ` Sergey Senozhatsky
2023-06-24 3:49 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox