From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A027BEB64D7 for ; Fri, 23 Jun 2023 15:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232466AbjFWPmK (ORCPT ); Fri, 23 Jun 2023 11:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232651AbjFWPmH (ORCPT ); Fri, 23 Jun 2023 11:42:07 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7017126BC; Fri, 23 Jun 2023 08:42:00 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 81B49838; Fri, 23 Jun 2023 17:41:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687534882; bh=vAvgOuo7ciMIJdwJYscA2jdeSsVY0tXeEX6+c1G6yUs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AhTrQcq0V0NHivubxoHGh6Ds97i2wVL7EETm/YajjkosrMXnyhS7b/zS86q5XoYbf pc5sp32yxe17PIVEwCGzvESweTETB/zgXhF5TdESW0fh87614QDSdWXkb9Gl6y7hgh Fk0PL2uoSazBvYuvhkCko6B+bmSgdNtYPGs92Jkg= Date: Fri, 23 Jun 2023 18:41:58 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/39] drm: renesas: shmobile: Convert to use devm_request_irq() Message-ID: <20230623154158.GT2112@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:28AM +0200, Geert Uytterhoeven wrote: > Convert to managed IRQ handling, to simplify cleanup. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > index 50fca18282c5cb5e..ece9aedde9b662d4 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > @@ -169,7 +169,6 @@ static int shmob_drm_remove(struct platform_device *pdev) > > drm_dev_unregister(ddev); > drm_kms_helper_poll_fini(ddev); > - free_irq(sdev->irq, ddev); > drm_dev_put(ddev); > > return 0; > @@ -252,8 +251,8 @@ static int shmob_drm_probe(struct platform_device *pdev) > goto err_modeset_cleanup; > sdev->irq = ret; > > - ret = request_irq(sdev->irq, shmob_drm_irq, 0, ddev->driver->name, > - ddev); > + ret = devm_request_irq(&pdev->dev, sdev->irq, shmob_drm_irq, 0, > + ddev->driver->name, ddev); > if (ret < 0) { > dev_err(&pdev->dev, "failed to install IRQ handler\n"); > goto err_modeset_cleanup; > @@ -265,14 +264,12 @@ static int shmob_drm_probe(struct platform_device *pdev) > */ > ret = drm_dev_register(ddev, 0); > if (ret < 0) > - goto err_irq_uninstall; > + goto err_modeset_cleanup; > > drm_fbdev_generic_setup(ddev, 16); > > return 0; > > -err_irq_uninstall: > - free_irq(sdev->irq, ddev); > err_modeset_cleanup: > drm_kms_helper_poll_fini(ddev); > err_free_drm_dev: -- Regards, Laurent Pinchart