From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4E1EB64DD for ; Fri, 23 Jun 2023 07:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbjFWHSL (ORCPT ); Fri, 23 Jun 2023 03:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230503AbjFWHSG (ORCPT ); Fri, 23 Jun 2023 03:18:06 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18BAA10C2; Fri, 23 Jun 2023 00:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687504685; x=1719040685; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=X0oSPt8MKPSCdlW2qvnEeXQx55EsL81HO4NU7W+GvPE=; b=chRqgEWRsnT1iFUMC8bkt8r3TBC/l2eji47cPeQpMtdZ/W2mrXNM3KxU wrHhkzPjeRoR6Dx4IMv2sH74/iyqYB9FGk7yLDSP0A24rE9vmoD2eH+L+ s7ZtyuKRWwXKkhzTby0Q8w/HF/cbPOMVUyULNyUz69VMnQ5pUrEwFtY+f GMoUxz5JJXg5dCM5OQ1V2GeDemLI8IBoJRj/z6Ro6rqveQKSooptE8nMn XfgwQmhRW39E7zc0dmGpQThktzA55EkJENYgnw2Husd7QvC4G5tIJkPqK 5xw5VH/DfCP/huAFapXeFgIOHc4Lr3/1EAUMKs+x4BoN+RBq6mpo/dyeI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="358197912" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="358197912" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 00:18:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="889382382" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="889382382" Received: from lkp-server01.sh.intel.com (HELO 783282924a45) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 23 Jun 2023 00:18:01 -0700 Received: from kbuild by 783282924a45 with local (Exim 4.96) (envelope-from ) id 1qCb3Q-00084f-1K; Fri, 23 Jun 2023 07:18:00 +0000 Date: Fri, 23 Jun 2023 15:17:43 +0800 From: kernel test robot To: Benjamin Bara , Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: oe-kbuild-all@lists.linux.dev, Alexander Stein , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 1/3] usb: misc: onboard-hub: support multiple power supplies Message-ID: <202306231557.18uGlgSW-lkp@intel.com> References: <20230620-hx3-v6-1-6a1d6f8ce689@skidata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230620-hx3-v6-1-6a1d6f8ce689@skidata.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, kernel test robot noticed the following build warnings: [auto build test WARNING on 45a3e24f65e90a047bef86f927ebdc4c710edaa1] url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Bara/usb-misc-onboard-hub-support-multiple-power-supplies/20230623-142256 base: 45a3e24f65e90a047bef86f927ebdc4c710edaa1 patch link: https://lore.kernel.org/r/20230620-hx3-v6-1-6a1d6f8ce689%40skidata.com patch subject: [PATCH v6 1/3] usb: misc: onboard-hub: support multiple power supplies config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230623/202306231557.18uGlgSW-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230623/202306231557.18uGlgSW-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306231557.18uGlgSW-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/usb/misc/onboard_usb_hub.c: In function 'onboard_hub_probe': >> drivers/usb/misc/onboard_usb_hub.c:262:59: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=] 262 | return dev_err_probe(dev, -EINVAL, "max %ld supplies supported!\n", | ~~^ | | | long int | %d vim +262 drivers/usb/misc/onboard_usb_hub.c 240 241 static int onboard_hub_probe(struct platform_device *pdev) 242 { 243 const struct of_device_id *of_id; 244 struct device *dev = &pdev->dev; 245 struct onboard_hub *hub; 246 unsigned int i; 247 int err; 248 249 hub = devm_kzalloc(dev, sizeof(*hub), GFP_KERNEL); 250 if (!hub) 251 return -ENOMEM; 252 253 of_id = of_match_device(onboard_hub_match, &pdev->dev); 254 if (!of_id) 255 return -ENODEV; 256 257 hub->pdata = of_id->data; 258 if (!hub->pdata) 259 return -EINVAL; 260 261 if (hub->pdata->num_supplies > MAX_SUPPLIES) > 262 return dev_err_probe(dev, -EINVAL, "max %ld supplies supported!\n", 263 MAX_SUPPLIES); 264 265 for (i = 0; i < hub->pdata->num_supplies; i++) 266 hub->supplies[i].supply = supply_names[i]; 267 268 err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies); 269 if (err) { 270 dev_err(dev, "Failed to get regulator supplies: %d\n", err); 271 return err; 272 } 273 274 hub->reset_gpio = devm_gpiod_get_optional(dev, "reset", 275 GPIOD_OUT_HIGH); 276 if (IS_ERR(hub->reset_gpio)) 277 return dev_err_probe(dev, PTR_ERR(hub->reset_gpio), "failed to get reset GPIO\n"); 278 279 hub->dev = dev; 280 mutex_init(&hub->lock); 281 INIT_LIST_HEAD(&hub->udev_list); 282 283 dev_set_drvdata(dev, hub); 284 285 err = onboard_hub_power_on(hub); 286 if (err) 287 return err; 288 289 /* 290 * The USB driver might have been detached from the USB devices by 291 * onboard_hub_remove() (e.g. through an 'unbind' by userspace), 292 * make sure to re-attach it if needed. 293 * 294 * This needs to be done deferred to avoid self-deadlocks on systems 295 * with nested onboard hubs. 296 */ 297 schedule_work(&attach_usb_driver_work); 298 299 return 0; 300 } 301 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki