From: Kees Cook <keescook@chromium.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Julia Lawall <julia.lawall@inria.fr>,
Manivannan Sadhasivam <mani@kernel.org>,
kernel-janitors@vger.kernel.org, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/26] bus: mhi: host: use array_size
Date: Fri, 23 Jun 2023 16:45:15 -0700 [thread overview]
Message-ID: <202306231639.68955384A@keescook> (raw)
In-Reply-To: <58cb3bf6-5ffd-194b-1455-4e5bb045fc34@quicinc.com>
On Fri, Jun 23, 2023 at 04:09:46PM -0600, Jeffrey Hugo wrote:
> Kees, would you please chime in and educate me here? I feel like I'm
> missing something important here.
The array_size() family will saturate at SIZE_MAX (rather than potentially
wrapping around). No allocator can fulfil a 18446744073709551615 byte
(18 exabyte) allocation. :) So the NULL return value will (hopefully)
trigger an error path.
--
Kees Cook
next prev parent reply other threads:[~2023-06-23 23:45 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 21:14 [PATCH 00/26] use array_size Julia Lawall
2023-06-23 21:14 ` [PATCH 01/26] lib/test_vmalloc.c: " Julia Lawall
2023-06-23 21:14 ` [PATCH 02/26] octeon_ep: " Julia Lawall
2023-06-24 15:46 ` Simon Horman
2023-06-24 22:28 ` Jakub Kicinski
2023-06-25 20:14 ` Christophe JAILLET
2023-06-25 20:25 ` Julia Lawall
2023-06-25 20:32 ` Christophe JAILLET
2023-06-25 20:57 ` Julia Lawall
2023-06-23 21:14 ` [PATCH 03/26] drm/gud: " Julia Lawall
2023-06-23 21:14 ` [PATCH 04/26] gve: " Julia Lawall
2023-06-24 15:47 ` Simon Horman
2023-06-23 21:14 ` [PATCH 05/26] RDMA/erdma: " Julia Lawall
2023-06-27 9:32 ` Cheng Xu
2023-06-23 21:14 ` [PATCH 06/26] dma-buf: system_heap: " Julia Lawall
2023-06-23 21:42 ` John Stultz
2023-06-23 21:14 ` [PATCH 07/26] scsi: fnic: " Julia Lawall
2023-06-23 21:14 ` [PATCH 08/26] virtio-mem: " Julia Lawall
2023-06-25 1:39 ` Xuan Zhuo
2023-06-26 7:40 ` David Hildenbrand
2023-06-26 10:59 ` Michael S. Tsirkin
2023-06-23 21:14 ` [PATCH 09/26] pds_core: " Julia Lawall
2023-06-24 15:47 ` Simon Horman
2023-06-26 16:02 ` Shannon Nelson
2023-06-23 21:14 ` [PATCH 10/26] bus: mhi: host: " Julia Lawall
2023-06-23 21:30 ` Jeffrey Hugo
2023-06-23 21:45 ` Julia Lawall
2023-06-23 22:09 ` Jeffrey Hugo
2023-06-23 23:45 ` Kees Cook [this message]
2023-06-24 16:06 ` Jeffrey Hugo
2023-06-26 11:46 ` Dan Carpenter
2023-06-26 14:53 ` Jeffrey Hugo
2023-06-23 21:14 ` [PATCH 11/26] ionic: " Julia Lawall
2023-06-24 15:47 ` Simon Horman
2023-06-26 16:03 ` Shannon Nelson
2023-06-23 21:14 ` [PATCH 12/26] btrfs: zoned: " Julia Lawall
2023-06-26 6:08 ` Johannes Thumshirn
2023-06-26 7:59 ` Naohiro Aota
2023-06-29 14:30 ` David Sterba
2023-06-23 21:14 ` [PATCH 13/26] iommu/tegra: gart: " Julia Lawall
2023-06-23 21:14 ` [PATCH 14/26] RDMA/siw: " Julia Lawall
2023-06-26 11:23 ` Bernard Metzler
2023-06-23 21:14 ` [PATCH 15/26] habanalabs: " Julia Lawall
2023-06-23 21:14 ` [PATCH 16/26] drm/i915/gvt: " Julia Lawall
2023-06-26 9:26 ` [Intel-gfx] " Andi Shyti
2023-06-26 11:54 ` Dan Carpenter
2023-06-23 21:14 ` [PATCH 17/26] kcov: " Julia Lawall
2023-06-24 5:34 ` Dmitry Vyukov
2023-06-23 21:14 ` [PATCH 18/26] net: enetc: " Julia Lawall
2023-06-24 15:48 ` Simon Horman
2023-06-23 21:14 ` [PATCH 19/26] RDMA/bnxt_re: " Julia Lawall
2023-06-23 21:14 ` [PATCH 20/26] drm/vmwgfx: " Julia Lawall
2023-06-27 17:33 ` Julia Lawall
2023-06-23 21:14 ` [PATCH 21/26] x86/sgx: " Julia Lawall
2023-07-10 22:02 ` Jarkko Sakkinen
2023-06-23 21:14 ` [PATCH 22/26] net: mana: " Julia Lawall
2023-06-24 15:48 ` Simon Horman
2023-06-23 21:14 ` [PATCH 23/26] media: staging: imgu: " Julia Lawall
2023-06-25 4:59 ` Bingbu Cao
2023-06-27 17:35 ` Julia Lawall
2023-06-29 7:34 ` Sakari Ailus
2023-06-23 21:14 ` [PATCH 24/26] scsi: qla2xxx: " Julia Lawall
2023-06-23 21:14 ` [PATCH 25/26] vduse: " Julia Lawall
2023-06-23 21:14 ` [PATCH 26/26] comedi: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306231639.68955384A@keescook \
--to=keescook@chromium.org \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox