From: "Krzysztof Wilczyński" <kw@linux.com>
To: Xinghui Li <korantwork@gmail.com>
Cc: dlemoal@kernel.org, helgaas@kernel.org,
nirmal.patel@linux.intel.com, kbusch@kernel.org,
jonathan.derrick@linux.dev, lpieralisi@kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Xinghui Li <korantli@tencent.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2 0/2] PCI: vmd: Fix two issues in VMD reported by Smatch
Date: Mon, 26 Jun 2023 02:03:55 +0900 [thread overview]
Message-ID: <20230625170355.GA2459283@rocinante> (raw)
In-Reply-To: <CAEm4hYUhRCBo=N9EKUaSbBWZafKk0WzzwDWYmJ4FykpQoeZe1w@mail.gmail.com>
Hello,
> > > PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch
> >
> > Even though this is a very nice clean-up, I did not take this patch at this
> > time, as there has been a similar patch posted in the past, and Christoph
> > Hellwig suggested, as part of his review, an alternative approach worth
> > considering.
> >
> > Have a look at the following and let me know what you think:
> >
> > https://patchwork.kernel.org/project/linux-pci/patch/20221115054847.77829-1-jiapeng.chong@linux.alibaba.com/
>
> I think Christoph Hellwig's suggestion is indeed better.
> So, should I submit a new patch to address this issue?
Please. A single new patch would suffice.
Make sure to explain as part of the commit log why this specific change
that started as a Smatch complaint about an incorrect indentation.
Thank you!
Krzysztof
prev parent reply other threads:[~2023-06-25 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 9:43 [PATCH v2 0/2] PCI: vmd: Fix two issues in VMD reported by Smatch korantwork
2023-04-20 9:43 ` [PATCH v2 1/2] PCI: vmd: Fix one uninitialized symbol error " korantwork
2023-04-20 23:59 ` Patel, Nirmal
2023-04-20 9:43 ` [PATCH v2 2/2] PCI: vmd: Clean up one inconsistent indenting warn " korantwork
2023-04-20 23:59 ` Patel, Nirmal
2023-06-24 16:33 ` [PATCH v2 0/2] PCI: vmd: Fix two issues in VMD " Krzysztof Wilczyński
2023-06-25 3:14 ` Xinghui Li
2023-06-25 17:03 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230625170355.GA2459283@rocinante \
--to=kw@linux.com \
--cc=dlemoal@kernel.org \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=kbusch@kernel.org \
--cc=korantli@tencent.com \
--cc=korantwork@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=nirmal.patel@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox