Re: [PATCH bpf-next 0/7] Support defragmenting IPv(4|6) packets in BPF

Daniel Xu
2023-06-29T17:59:14Z

On Thu, Jun 29, 2023 at 04:53:15PM +0200, Florian Westphal wrote:
> Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> > Florian Westphal <fw@strlen.de> writes:
> > As for the original question, that's answered by your point above: If
> > those two modules are the only ones that are likely to need this, then a
> > flag for each is fine by me - that was the key piece I was missing (I'm
> > not a netfilter expert, as you well know).
>
> No problem, I was worried I was missing an important piece of kfunc
> plumbing :-)
>
> You do raise a good point though. With kfuncs, module is pinned.
> So, should a "please turn on defrag for this bpf_link" pin
> the defrag modules too?
>
> For plain netfilter we don't do that, i.e. you can just do
> "rmmod nf_defrag_ipv4". But I suspect that for the new bpf-link
> defrag we probably should grab a reference to prevent unwanted
> functionality breakage of the bpf prog.

Ack. Will add to v3.

Thanks,
Daniel