From: Waiman Long <longman@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
x86@kernel.org, linux-pm@vger.kernel.org,
Robin Jarry <rjarry@redhat.com>, Joe Mario <jmario@redhat.com>,
Waiman Long <longman@redhat.com>
Subject: [PATCH v4 1/4] x86/speculation: Add __update_spec_ctrl() helper
Date: Tue, 27 Jun 2023 22:25:51 -0400 [thread overview]
Message-ID: <20230628022554.1638318-2-longman@redhat.com> (raw)
In-Reply-To: <20230628022554.1638318-1-longman@redhat.com>
Add a new __update_spec_ctrl() helper which is a variant of
update_spec_ctrl() that can be used in a noinstr function.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Waiman Long <longman@redhat.com>
---
arch/x86/include/asm/nospec-branch.h | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index 55388c9f7601..1d363fcea207 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -9,7 +9,7 @@
#include <asm/alternative.h>
#include <asm/cpufeatures.h>
-#include <asm/msr-index.h>
+#include <asm/msr.h>
#include <asm/unwind_hints.h>
#include <asm/percpu.h>
#include <asm/current.h>
@@ -488,6 +488,15 @@ DECLARE_PER_CPU(u64, x86_spec_ctrl_current);
extern void update_spec_ctrl_cond(u64 val);
extern u64 spec_ctrl_current(void);
+/*
+ * This can be used in noinstr function.
+ */
+static __always_inline void __update_spec_ctrl(u64 val)
+{
+ __this_cpu_write(x86_spec_ctrl_current, val);
+ native_wrmsrl(MSR_IA32_SPEC_CTRL, val);
+}
+
/*
* With retpoline, we must use IBRS to restrict branch prediction
* before calling into firmware.
--
2.31.1
next prev parent reply other threads:[~2023-06-28 2:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 2:25 [PATCH v4 0/4] x86/speculation: Disable IBRS when idle Waiman Long
2023-06-28 2:25 ` Waiman Long [this message]
2023-07-03 10:28 ` [PATCH v4 1/4] x86/speculation: Add __update_spec_ctrl() helper Peter Zijlstra
2023-07-03 15:08 ` Waiman Long
2023-06-28 2:25 ` [PATCH v4 2/4] x86/idle: Disable IBRS when cpu is offline Waiman Long
2023-06-28 2:25 ` [PATCH v4 3/4] intel_idle: Use __update_spec_ctrl() in intel_idle_ibrs() Waiman Long
2023-06-28 2:25 ` [PATCH v4 4/4] intel_idle: Add ibrs_off module parameter to force disable IBRS Waiman Long
2023-06-28 2:58 ` Randy Dunlap
2023-06-29 3:03 ` Waiman Long
2023-07-03 10:32 ` Peter Zijlstra
2023-07-03 15:09 ` Waiman Long
2023-06-28 17:13 ` [PATCH v4 0/4] x86/speculation: Disable IBRS when idle Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628022554.1638318-2-longman@redhat.com \
--to=longman@redhat.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jmario@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjarry@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox