Re: [for-linus][PATCH 0/3] tracing: Final updates for 6.4+

Steven Rostedt
2023-06-28T14:08:28Z

On Wed, 28 Jun 2023 08:54:48 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> The user events write currently returns the size of what was suppose to be
> written when tracing is disabled and nothing was written. Instead, behave like
> trace_marker and return -EBADF, as that is what is returned if a file is opened
> for read only,

I accidentally sent this before it was ready to go (I was editing the
change log from the previous one) I didn't finish the above paragraph,
and was suppose to delete the below one.

That's because I was about to rush to a talk at EOSS, and hit save and
exit forgetting that sends the emails out! (I'm using quilt)

I'll finish it properly for when I do the proper pull request.

-- Steve

>
> Before user events become an ABI, fix the return value of the write
> operation when tracing is disabled. It should not return an error, but
> simply report it wrote zero bytes. Just like any other write operation
> that doesn't write but does not "fail".
>
> This also includes test cases for this use case.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
> trace/urgent
>
> Head SHA1: e155047e53d25f09d055c08ae9d6c269520e90d8
>
>
> sunliming (3):
> tracing/user_events: Fix incorrect return value for writing operation when events are disabled
> selftests/user_events: Enable the event before write_fault test in ftrace self-test
> selftests/user_events: Add test cases when event is disabled
>
> ----
> kernel/trace/trace_events_user.c | 3 ++-
> tools/testing/selftests/user_events/ftrace_test.c | 8 ++++++++
> 2 files changed, 10 insertions(+), 1 deletion(-)