Re: [PATCH 2/2] regulator: rt5739: Add DID check and compatible for rt5733

Mark Brown
2023-06-28T11:48:26Z

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Wed, Jun 28, 2023 at 04:47:17PM +0800, cy_huang@richtek.com wrote:

> + if (did == RT5733_CHIPDIE_ID) {
> + min_uV = RT5733_VOLT_MINUV;
> + max_uV = RT5733_VOLT_MAXUV;
> + step_uV = RT5733_VOLT_STPUV;
> + } else {
> + min_uV = RT5739_VOLT_MINUV;
> + max_uV = RT5739_VOLT_MAXUV;
> + step_uV = RT5739_VOLT_STPUV;
> + }

It would be better to write these as switch statements so if any more
variants turn up they can be added more easily.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]