public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Beau Belgrave <beaub@linux.microsoft.com>
To: rostedt@goodmis.org, mhiramat@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: [PATCH 0/2] tracing/user_events: Fix struct arg size match check
Date: Thu, 29 Jun 2023 23:50:47 +0000	[thread overview]
Message-ID: <20230629235049.581-1-beaub@linux.microsoft.com> (raw)

The edge case of struct fields having an extra size argument got missed
when checking if events have the same name and arguments. This lead to
events not being able to register if a matching event name was already
created with a struct argument.

This series simply fixes this and adds a self test to ensure we do not
miss it again.

Beau Belgrave (2):
  tracing/user_events: Fix struct arg size match check
  selftests/user_events: Test struct size match cases

 kernel/trace/trace_events_user.c               |  3 +++
 tools/testing/selftests/user_events/dyn_test.c | 12 ++++++++++++
 2 files changed, 15 insertions(+)


base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1
-- 
2.34.1


             reply	other threads:[~2023-06-29 23:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 23:50 Beau Belgrave [this message]
2023-06-29 23:50 ` [PATCH 1/2] tracing/user_events: Fix struct arg size match check Beau Belgrave
2023-06-29 23:50 ` [PATCH 2/2] selftests/user_events: Test struct size match cases Beau Belgrave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230629235049.581-1-beaub@linux.microsoft.com \
    --to=beaub@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox