public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
@ 2023-06-30 11:38 Stuart Hayhurst
  2023-06-30 11:51 ` Bastien Nocera
  2023-07-10  8:32 ` Benjamin Tissoires
  0 siblings, 2 replies; 3+ messages in thread
From: Stuart Hayhurst @ 2023-06-30 11:38 UTC (permalink / raw)
  Cc: Stuart Hayhurst, linux-kernel, linux-input, Benjamin Tissoires,
	Jiri Kosina, Bastien Nocera, Filipe Laíns

Previously, support for the G502 had been attempted in commit
'27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more supported mice")'

This caused some issues and was reverted by
'addf3382c47c ("Revert "HID: logitech-hidpp: add USB PID for a few more
supported mice"")'.

Since then, a new version of this mouse has been released (Lightpseed Wireless), and works correctly.

This device has support for battery reporting with the driver

Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
---

Changes:
v3:
 - Add git commit titles
v2:
 - Add commit references

---
 drivers/hid/hid-logitech-hidpp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 5e1a412fd28f..94a045ef8e50 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4598,6 +4598,8 @@ static const struct hid_device_id hidpp_devices[] = {
 
 	{ /* Logitech G403 Wireless Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
+	{ /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
 	{ /* Logitech G703 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
 	{ /* Logitech G703 Hero Gaming Mouse over USB */
-- 
2.40.1.521.gf1e218fcd8


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
  2023-06-30 11:38 [PATCH v3] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed Stuart Hayhurst
@ 2023-06-30 11:51 ` Bastien Nocera
  2023-07-10  8:32 ` Benjamin Tissoires
  1 sibling, 0 replies; 3+ messages in thread
From: Bastien Nocera @ 2023-06-30 11:51 UTC (permalink / raw)
  To: Stuart Hayhurst
  Cc: linux-kernel, linux-input, Benjamin Tissoires, Jiri Kosina,
	Filipe Laíns

On Fri, 2023-06-30 at 12:38 +0100, Stuart Hayhurst wrote:
> Previously, support for the G502 had been attempted in commit
> '27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more
> supported mice")'
> 
> This caused some issues and was reverted by
> 'addf3382c47c ("Revert "HID: logitech-hidpp: add USB PID for a few
> more
> supported mice"")'.
> 
> Since then, a new version of this mouse has been released (Lightpseed
> Wireless), and works correctly.
> 
> This device has support for battery reporting with the driver
> 
> Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>

Reviewed-by: Bastien Nocera <hadess@hadess.net>

> ---
> 
> Changes:
> v3:
>  - Add git commit titles
> v2:
>  - Add commit references
> 
> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 5e1a412fd28f..94a045ef8e50 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4598,6 +4598,8 @@ static const struct hid_device_id
> hidpp_devices[] = {
>  
>         { /* Logitech G403 Wireless Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
> +       { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB
> */
> +         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
>         { /* Logitech G703 Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
>         { /* Logitech G703 Hero Gaming Mouse over USB */


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
  2023-06-30 11:38 [PATCH v3] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed Stuart Hayhurst
  2023-06-30 11:51 ` Bastien Nocera
@ 2023-07-10  8:32 ` Benjamin Tissoires
  1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2023-07-10  8:32 UTC (permalink / raw)
  To: Stuart Hayhurst
  Cc: linux-kernel, linux-input, Benjamin Tissoires, Jiri Kosina,
	Bastien Nocera, Filipe Laíns

On Fri, 30 Jun 2023 12:38:20 +0100, Stuart Hayhurst wrote:
> Previously, support for the G502 had been attempted in commit
> '27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more supported mice")'
> 
> This caused some issues and was reverted by
> 'addf3382c47c ("Revert "HID: logitech-hidpp: add USB PID for a few more
> supported mice"")'.
> 
> [...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.5/upstream-fixes), thanks!

[1/1] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
      https://git.kernel.org/hid/hid/c/a343a7682acc

Cheers,
-- 
Benjamin Tissoires <bentiss@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-10  8:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-30 11:38 [PATCH v3] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed Stuart Hayhurst
2023-06-30 11:51 ` Bastien Nocera
2023-07-10  8:32 ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox