From: Johan Hovold <johan+linaro@kernel.org>
To: Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 2/5] ASoC: codecs: wcd938x: drop inline keywords
Date: Fri, 30 Jun 2023 16:27:14 +0200 [thread overview]
Message-ID: <20230630142717.5314-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org>
The compiler is generally better at deciding what functions should be
inlined than driver authors are.
Drop the bogus inline keyword from two functions that were neither very
small or used in a single place.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
sound/soc/codecs/wcd938x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index b8a52a1a63d5..5ce15b622a91 100644
--- a/sound/soc/codecs/wcd938x.c
+++ b/sound/soc/codecs/wcd938x.c
@@ -2124,7 +2124,7 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *compon
return wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2);
}
-static inline void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x,
+static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x,
s16 *d1_a, u16 noff,
int32_t *zdet)
{
@@ -2231,8 +2231,8 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_component *component,
*zr = zdet;
}
-static inline void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component,
- int32_t *z_val, int flag_l_r)
+static void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component,
+ int32_t *z_val, int flag_l_r)
{
s16 q1;
int q1_cal;
--
2.39.3
next prev parent reply other threads:[~2023-06-30 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 14:27 [PATCH 0/5] ASoC: codecs: wcd938x/wcd934x: loglevel fix and cleanups Johan Hovold
2023-06-30 14:27 ` [PATCH 1/5] ASoC: codecs: wcd938x: fix mbhc impedance loglevel Johan Hovold
2023-06-30 15:54 ` Mark Brown
2023-06-30 14:27 ` Johan Hovold [this message]
2023-06-30 14:27 ` [PATCH 3/5] ASoC: codecs: wcd938x: use dev_printk() for impedance logging Johan Hovold
2023-06-30 15:54 ` Mark Brown
2023-06-30 14:27 ` [PATCH 4/5] ASoC: codecs: wcd934x: demote impedance printk Johan Hovold
2023-06-30 14:27 ` [PATCH 5/5] ASoC: codecs: wcd934x: drop inline keywords Johan Hovold
2023-06-30 15:02 ` [PATCH 0/5] ASoC: codecs: wcd938x/wcd934x: loglevel fix and cleanups Srinivas Kandagatla
2023-07-03 15:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630142717.5314-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox