Re: [PATCH v5 06/11] ARM: dts: bcm2711: Add unicam CSI nodes

Stefan Wahren
2022-02-13T13:52:30Z

Am 13.02.22 um 11:35 schrieb Stefan Wahren:
> Hi Jean-Michel,
>
> Am 08.02.22 um 16:50 schrieb Jean-Michel Hautbois:
>> +
>> &firmware {
>> firmware_clocks: clocks {
>> compatible = "raspberrypi,firmware-clocks";
>> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
>> index dff18fc9a906..21eb10122e50 100644
>> --- a/arch/arm/boot/dts/bcm2711.dtsi
>> +++ b/arch/arm/boot/dts/bcm2711.dtsi
>> @@ -293,6 +293,28 @@ hvs: hvs@7e400000 {
>> interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>> };
>>
>> + csi0: csi@7e800000 {
>> + compatible = "brcm,bcm2835-unicam";
>> + reg = <0x7e800000 0x800>,
>> + <0x7e802000 0x4>;
>> + reg-names = "unicam", "cmi";
>> + interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
>> + status = "disabled";
>> + port {
>> + };
>> + };
>> +
>> + csi1: csi@7e801000 {
>> + compatible = "brcm,bcm2835-unicam";
>> + reg = <0x7e801000 0x800>,
>> + <0x7e802004 0x4>;
>> + reg-names = "unicam", "cmi";
>> + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
>> + status = "disabled";
>> + port {
>> + };
>> + };
>> +
> i didn't noticed before that everything except of the interrupts are
> identical to the bcm283x boards [1]. So please define both nodes in
> bcm283x.dtsi (with bcm283x interrupts) and just override the interrupts
> for bcm2711 in this dtsi file.
>
> As a result the clocks and power domains from above can go to
> bcm2835-rpi.dtsi.

sorry, i forgot the downstream link:

[1] -
https://github.com/raspberrypi/linux/blob/rpi-5.15.y/arch/arm/boot/dts/bcm270x.dtsi#L88

>
>> pixelvalve3: pixelvalve@7ec12000 {
>> compatible = "brcm,bcm2711-pixelvalve3";
>> reg = <0x7ec12000 0x100>;