From: Arnd Bergmann <arnd@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Christian Brauner <brauner@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ovl: mark ovl_redirect_mode() as static again
Date: Mon, 3 Jul 2023 13:31:33 +0200 [thread overview]
Message-ID: <20230703113142.424670-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
This function was moved to another file and is no longer marked
static there, causing a W=1 warning:
fs/overlayfs/params.c:92:13: error: no previous prototype for 'ovl_redirect_mode' [-Werror=missing-prototypes]
This was probably lost by accident during the refactoring, as there is
still no caller in another file, so add back the annotation.
Fixes: 06bcaa2dafb7e ("ovl: move all parameter handling into params.{c,h}")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/overlayfs/params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
index b8c2f6056a9a8..a63160dbb0f95 100644
--- a/fs/overlayfs/params.c
+++ b/fs/overlayfs/params.c
@@ -89,7 +89,7 @@ const struct constant_table ovl_parameter_redirect_dir[] = {
{}
};
-const char *ovl_redirect_mode(struct ovl_config *config)
+static const char *ovl_redirect_mode(struct ovl_config *config)
{
return ovl_parameter_redirect_dir[config->redirect_mode].name;
}
--
2.39.2
next reply other threads:[~2023-07-03 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 11:31 Arnd Bergmann [this message]
2023-07-03 12:53 ` [PATCH] ovl: mark ovl_redirect_mode() as static again Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703113142.424670-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=amir73il@gmail.com \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox