From: Peter Zijlstra <peterz@infradead.org>
To: Phil Auld <pauld@redhat.com>
Cc: linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Valentin Schneider <vschneid@redhat.com>,
Ben Segall <bsegall@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mel Gorman <mgorman@suse.de>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH v4] Sched/fair: Block nohz tick_stop when cfs bandwidth in use
Date: Mon, 3 Jul 2023 14:10:09 +0200 [thread overview]
Message-ID: <20230703121009.GH4253@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230630162910.GD43299@lorien.usersys.redhat.com>
On Fri, Jun 30, 2023 at 12:29:10PM -0400, Phil Auld wrote:
> I think you are agreeing that I need the pick next code but need to remove
> the hierarchy walks, right?
Yeah, the dequeue case makes we have to care about pick, not sure we
then also need to care about sched_update_tick_dependency() though.
There is indeed a window where these two will 'race', but afaict it is
benign.
next prev parent reply other threads:[~2023-07-03 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 13:57 [PATCH v4] Sched/fair: Block nohz tick_stop when cfs bandwidth in use Phil Auld
2023-06-30 15:06 ` Peter Zijlstra
2023-06-30 15:28 ` Phil Auld
2023-06-30 16:05 ` Peter Zijlstra
2023-06-30 16:29 ` Phil Auld
2023-07-03 12:10 ` Peter Zijlstra [this message]
2023-07-03 14:10 ` Phil Auld
2023-07-03 14:19 ` Phil Auld
2023-07-03 14:32 ` Peter Zijlstra
2023-07-03 15:24 ` Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703121009.GH4253@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox