From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 2/2] mfd: ipaq-micro: Add missing break for the default case
Date: Mon, 3 Jul 2023 17:09:23 +0300 [thread overview]
Message-ID: <20230703140923.2840-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230703140923.2840-1-andriy.shevchenko@linux.intel.com>
Even default case should have a break statement to make code robust
against changes (e.g., adding a case after the default one).
Add missing break for the default case.
---
v2: new patch
drivers/mfd/ipaq-micro.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index cddfd2e808f2..57fb7874fc91 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -132,6 +132,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
default:
dev_err(micro->dev,
"unknown msg %d [%d] %*ph\n", id, len, len, data);
+ break;
}
spin_unlock(µ->lock);
}
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-07-03 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 14:09 [PATCH v2 1/2] mfd: ipaq-micro: Use %*ph for printing hexdump of a small buffer Andy Shevchenko
2023-07-03 14:09 ` Andy Shevchenko [this message]
2023-07-13 10:20 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703140923.2840-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox