Re: [PATCH 5.15 00/15] 5.15.120-rc1 review

Greg Kroah-Hartman
2023-07-04T07:32:02Z

On Tue, Jul 04, 2023 at 09:16:36AM +0200, Helge Deller wrote:
> On 7/4/23 09:00, Naresh Kamboju wrote:
> > On Tue, 4 Jul 2023 at 00:27, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 5.15.120 release.
> > > There are 15 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 05 Jul 2023 18:45:08 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.120-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Following build regressions noticed on stable-rc 5.15.
> > This build failure started happening from v5.15.119 from date June 28, 2023.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Regressions found on parisc:
> >
> > - build/gcc-11-allnoconfig
> > - build/gcc-11-defconfig
> > - build/gcc-11-tinyconfig
> >
> > Build errors:
> > =============
> > arch/parisc/include/asm/assembly.h: Assembler messages:
> > arch/parisc/include/asm/assembly.h:75: Error: symbol `sp' is already defined
> > arch/parisc/include/asm/assembly.h:77: Error: symbol `ipsw' is already defined
> > make[3]: *** [scripts/Makefile.build:391: arch/parisc/kernel/head.o] Error 1
> > arch/parisc/include/asm/assembly.h: Assembler messages:
>
> Greg, could you please pull in the following upstream commit?
> It was backported to kernels > 6.0, but with newer binutils it's probably
> needed for kernels < 6.0 as well:
>
> commit b5b2a02bcaac7c287694aa0db4837a07bf178626
> Author: Ben Hutchings <benh@debian.org>
> Date: Thu Jun 15 00:00:02 2023 +0200
>
> parisc: Delete redundant register definitions in <asm/assembly.h>
>
> We define sp and ipsw in <asm/asmregs.h> using ".reg", and when using
> current binutils (snapshot 2.40.50.20230611) the definitions in
> <asm/assembly.h> using "=" conflict with those:
>
> arch/parisc/include/asm/assembly.h: Assembler messages:
> arch/parisc/include/asm/assembly.h:93: Error: symbol `sp' is already defined
> arch/parisc/include/asm/assembly.h:95: Error: symbol `ipsw' is already defined
>
> Delete the duplicate definitions in <asm/assembly.h>.
>
> Also delete the definition of gp, which isn't used anywhere.
>
> Signed-off-by: Ben Hutchings <benh@debian.org>
> Cc: stable@vger.kernel.org # v6.0+
> Signed-off-by: Helge Deller <deller@gmx.de>

Sure, now queued up!

I'll be pushing out some -rc2 releases soon with this fix, and a few
others that I missed in a bit.

thanks for the report and the quick response,

greg k-h