public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hsia-Jun Li <randy.li@synaptics.com>
To: linux-media@vger.kernel.org
Cc: ayaka@soulik.info, hans.verkuil@cisco.com, tfiga@chromium.org,
	mchehab@kernel.org, laurent.pinchart@ideasonboard.com,
	hiroh@chromium.org, hverkuil@xs4all.nl,
	linux-kernel@vger.kernel.org, nicolas@ndufresne.ca,
	"Hsia-Jun(Randy) Li" <randy.li@synaptics.com>
Subject: [PATCH 2/2] media: v4l2-mem2mem: add a list for buf used by hw
Date: Tue,  4 Jul 2023 12:00:38 +0800	[thread overview]
Message-ID: <20230704040044.681850-3-randy.li@synaptics.com> (raw)
In-Reply-To: <20230704040044.681850-1-randy.li@synaptics.com>

From: "Hsia-Jun(Randy) Li" <randy.li@synaptics.com>

Many drivers have to create its own buf_struct for a
vb2_queue to track such a state. Also driver has to
iterate over rdy_queue every times to find out a buffer
which is not sent to hardware(or firmware), this new
list just offers the driver a place to store the buffer
that hardware(firmware) has acknowledged.

One important advance about this list, it doesn't like
rdy_queue which both bottom half of the user calling
could operate it, while the v4l2 worker would as well.
The v4l2 core could only operate this queue when its
v4l2_context is not running, the driver would only
access this new hw_queue in its own worker.

Signed-off-by: Hsia-Jun(Randy) Li <randy.li@synaptics.com>
---
 drivers/media/v4l2-core/v4l2-mem2mem.c | 25 +++++++++++++++++--------
 include/media/v4l2-mem2mem.h           | 10 +++++++++-
 2 files changed, 26 insertions(+), 9 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c
index c771aba42015..b4151147d5bd 100644
--- a/drivers/media/v4l2-core/v4l2-mem2mem.c
+++ b/drivers/media/v4l2-core/v4l2-mem2mem.c
@@ -321,15 +321,21 @@ static void __v4l2_m2m_try_queue(struct v4l2_m2m_dev *m2m_dev,
 		goto job_unlock;
 	}
 
-	src = v4l2_m2m_next_src_buf(m2m_ctx);
-	dst = v4l2_m2m_next_dst_buf(m2m_ctx);
-	if (!src && !m2m_ctx->out_q_ctx.buffered) {
-		dprintk("No input buffers available\n");
-		goto job_unlock;
+	if (list_empty(&m2m_ctx->out_q_ctx.hw_queue)) {
+		src = v4l2_m2m_next_src_buf(m2m_ctx);
+
+		if (!src && !m2m_ctx->out_q_ctx.buffered) {
+			dprintk("No input buffers available\n");
+			goto job_unlock;
+		}
 	}
-	if (!dst && !m2m_ctx->cap_q_ctx.buffered) {
-		dprintk("No output buffers available\n");
-		goto job_unlock;
+
+	if (list_empty(&m2m_ctx->cap_q_ctx.hw_queue)) {
+		dst = v4l2_m2m_next_dst_buf(m2m_ctx);
+		if (!dst && !m2m_ctx->cap_q_ctx.buffered) {
+			dprintk("No output buffers available\n");
+			goto job_unlock;
+		}
 	}
 
 	m2m_ctx->new_frame = true;
@@ -896,6 +902,7 @@ int v4l2_m2m_streamoff(struct file *file, struct v4l2_m2m_ctx *m2m_ctx,
 	INIT_LIST_HEAD(&q_ctx->rdy_queue);
 	q_ctx->num_rdy = 0;
 	spin_unlock_irqrestore(&q_ctx->rdy_spinlock, flags);
+	INIT_LIST_HEAD(&q_ctx->hw_queue);
 
 	if (m2m_dev->curr_ctx == m2m_ctx) {
 		m2m_dev->curr_ctx = NULL;
@@ -1234,6 +1241,8 @@ struct v4l2_m2m_ctx *v4l2_m2m_ctx_init(struct v4l2_m2m_dev *m2m_dev,
 
 	INIT_LIST_HEAD(&out_q_ctx->rdy_queue);
 	INIT_LIST_HEAD(&cap_q_ctx->rdy_queue);
+	INIT_LIST_HEAD(&out_q_ctx->hw_queue);
+	INIT_LIST_HEAD(&cap_q_ctx->hw_queue);
 	spin_lock_init(&out_q_ctx->rdy_spinlock);
 	spin_lock_init(&cap_q_ctx->rdy_spinlock);
 
diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h
index d6c8eb2b5201..2342656e582d 100644
--- a/include/media/v4l2-mem2mem.h
+++ b/include/media/v4l2-mem2mem.h
@@ -53,9 +53,16 @@ struct v4l2_m2m_dev;
  *	processed
  *
  * @q:		pointer to struct &vb2_queue
- * @rdy_queue:	List of V4L2 mem-to-mem queues
+ * @rdy_queue:	List of V4L2 mem-to-mem queues. If v4l2_m2m_buf_queue() is
+ *		called in struct vb2_ops->buf_queue(), the buffer enqueued
+ *		by user would be added to this list.
  * @rdy_spinlock: spin lock to protect the struct usage
  * @num_rdy:	number of buffers ready to be processed
+ * @hw_queue:	A list for tracking the buffer is occupied by the hardware
+ * 		(or device's firmware). A buffer could only be in either
+ * 		this list or @rdy_queue.
+ * 		Driver may choose not to use this list while uses its own
+ * 		private data to do this work.
  * @buffered:	is the queue buffered?
  *
  * Queue for buffers ready to be processed as soon as this
@@ -68,6 +75,7 @@ struct v4l2_m2m_queue_ctx {
 	struct list_head	rdy_queue;
 	spinlock_t		rdy_spinlock;
 	u8			num_rdy;
+	struct list_head	hw_queue;
 	bool			buffered;
 };
 
-- 
2.17.1


  parent reply	other threads:[~2023-07-04  4:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04  4:00 [PATCH 0/2] Improve V4L2 M2M job scheduler Hsia-Jun Li
2023-07-04  4:00 ` [PATCH 1/2] [RESEND] media: v4l2-mem2mem: allow device run without buf Hsia-Jun Li
2023-07-07 19:14   ` Nicolas Dufresne
2023-07-12  9:31     ` Tomasz Figa
2023-07-12  9:44       ` Sebastian Fricke
2023-07-13  3:13         ` Tomasz Figa
2023-07-17 14:00       ` Nicolas Dufresne
2023-07-21  8:56         ` Hsia-Jun Li
2023-07-21 16:22           ` Nicolas Dufresne
2023-07-24 17:29             ` Randy Li
2023-07-04  4:00 ` Hsia-Jun Li [this message]
2023-07-07 19:20   ` [PATCH 2/2] media: v4l2-mem2mem: add a list for buf used by hw Nicolas Dufresne
2023-07-11  8:54     ` Randy Li
2023-07-11  6:26   ` Dan Carpenter
2023-07-12  9:33   ` Tomasz Figa
2023-07-17  7:14     ` Hsia-Jun Li
2023-07-27  7:25       ` Tomasz Figa
2023-07-27  7:33         ` Hsia-Jun Li
2023-07-27  7:54           ` Tomasz Figa
2023-07-17 14:07     ` Nicolas Dufresne
2023-07-18  3:53       ` Hsia-Jun Li
2023-07-27  7:43       ` Tomasz Figa
2023-07-27 16:58         ` Nicolas Dufresne
2023-07-28  4:43           ` Tomasz Figa
2023-07-28  7:08             ` Hsia-Jun Li
2023-07-28  7:26               ` Tomasz Figa
2023-07-28  7:37                 ` Hsia-Jun Li
2023-07-28 16:19                   ` Nicolas Dufresne
2023-08-03 16:16                     ` Randy Li
2023-08-04 20:42                       ` Nicolas Dufresne
2023-07-28 16:09             ` Nicolas Dufresne
2023-08-18 14:45 ` [PATCH 0/2] Improve V4L2 M2M job scheduler Hans Verkuil
2023-08-22  7:59   ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230704040044.681850-3-randy.li@synaptics.com \
    --to=randy.li@synaptics.com \
    --cc=ayaka@soulik.info \
    --cc=hans.verkuil@cisco.com \
    --cc=hiroh@chromium.org \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas@ndufresne.ca \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox